Fix inference for attrs.fields #15688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Jul 28, 2023
There was a problem hiding this comment.
FWIW, I don't think this is a hack. This is more consistent with e.g. tuple_fallback() than the current behavior: tuple_fallback() just returns the fallback if it is non-trivial, so here too, we should just copy the logic for instances, if the fallback is non-trivial.
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Aug 31, 2023
This e.g. makes sure both code paths receive my fix in python#15688
JukkaL
pushed a commit
that referenced
this pull request
Sep 1, 2023
This e.g. makes sure both code paths receive my fix in #15688
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15393. A little hacky, but not an unreasonable way of providing type context.