Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up recursive type check #14326

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Speed up recursive type check #14326

merged 1 commit into from
Dec 20, 2022

Conversation

JukkaL
Copy link
Collaborator

@JukkaL JukkaL commented Dec 20, 2022

Use a faster type query visitor and reuse visitor across calls.

This should speed up type checking slightly. My measurements show a ~0.5% improvement, but it may be below the noise floor.

Use a faster type query visitor and reuse visitor across calls.

This should speed up type checking slightly. My measurements show
a ~0.5% improvement, but it may be below the noise floor.
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@JukkaL JukkaL merged commit 7ed4f5e into master Dec 20, 2022
@JukkaL JukkaL deleted the faster-recursive-1 branch December 20, 2022 17:12
JukkaL added a commit that referenced this pull request Dec 21, 2022
Use a faster type query visitor and reuse visitor across calls.

This should speed up type checking slightly. My measurements show a
~0.5% improvement, but it may be below the noise floor.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant