Revert to treating exclude in .ini as single string #11881
Conversation
Partially reverts python#11329 (with respect to `.ini` documentation). Modifies existing unit tests. Fixes python#11830.
|
Docs build cleanly with no broken links associated with this change. |
| which mypy should ignore while recursively discovering files to check. | ||
| Use forward slashes on all platforms. | ||
|
|
||
| .. code-block:: ini | ||
|
|
||
| [mypy] | ||
| exclude = | ||
| exclude = (?x)( |
There was a problem hiding this comment.
It might be worth it to note that the x flag causes whitespace, and lines beginning with #, to be ignored inside the pattern. A link to https://docs.python.org/3/library/re.html#re.X would save having to include further explanations.
There was a problem hiding this comment.
Something like:
(?x) can be used as the first part of a regular expression. This corresponds to setting the re.X flag, which causes most witespace in the pattern to be ignored. Everything after an unescaped # is also ignored, allowing for comments. The Python re module has more information.
There was a problem hiding this comment.
I tinkered with it a bit. Let me know what you think.
The hyperlink goes to https://docs.python.org/3/library/re.html#re.X.
There was a problem hiding this comment.
I love it! Thanks for accepting feedback.
Co-authored-by: Matthew W <matthew@willcockson.family>
Add explanation of regex in ``.ini`` example per @mawillcockson's suggestion.
|
Hooray, thanks for fixing this! |
Partially reverts python#11329 (with respect to `.ini` documentation). Modifies existing unit tests. Fixes python#11830. Co-authored-by: Matthew W <matthew@willcockson.family>
ghost
mentioned this pull request
Partially reverts #11329 (with respect to
.inidocumentation).Modifies existing unit tests.
Fixes #11830.