Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Python 3.10.1 (2) #11756

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Fix tests for Python 3.10.1 (2) #11756

merged 2 commits into from
Dec 16, 2021

Conversation

cdce8p
Copy link
Collaborator

@cdce8p cdce8p commented Dec 15, 2021

Description

Followup to #11752 The syntax error changed between 3.10.0 and 3.10.1.
https://bugs.python.org/issue46004

I missed a few the first time around unfortunately.
https://bugs.python.org/issue46004

Instead of duplicating the original output, I chose to extend the test syntax introduced with #10404 and added support for == version checks.

Test Plan

The test runner here still uses 3.10.0.
To test 3.10.1 I opened the same PR on my own fork: cdce8p#2. There it runs on 3.10.1.

@cdce8p cdce8p marked this pull request as draft December 15, 2021 19:47
@cdce8p cdce8p marked this pull request as ready for review December 15, 2021 22:21
@cdce8p cdce8p mentioned this pull request Dec 16, 2021
Copy link
Collaborator

@JukkaL JukkaL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL JukkaL merged commit 18d5669 into python:master Dec 16, 2021
@cdce8p cdce8p deleted the fix-tests-2 branch December 16, 2021 11:32
JukkaL pushed a commit that referenced this pull request Dec 16, 2021
Followup to #11752. The syntax error changed between 3.10.0 and 3.10.1.
https://bugs.python.org/issue46004

I missed a few the first time around unfortunately.
https://bugs.python.org/issue46004

Instead of duplicating the original output, I chose to extend the test syntax 
introduced with #10404 and added support for == version checks.
tushar-deepsource pushed a commit to DeepSourceCorp/mypy that referenced this pull request Jan 20, 2022
Followup to python#11752. The syntax error changed between 3.10.0 and 3.10.1.
https://bugs.python.org/issue46004

I missed a few the first time around unfortunately.
https://bugs.python.org/issue46004

Instead of duplicating the original output, I chose to extend the test syntax 
introduced with python#10404 and added support for == version checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants