Skip to content

Commit

Permalink
Remove some now out-of-date comments.
Browse files Browse the repository at this point in the history
  • Loading branch information
msullivan committed Mar 1, 2018
1 parent afe715d commit 893e1da
Showing 1 changed file with 0 additions and 14 deletions.
14 changes: 0 additions & 14 deletions mypy/build.py
Original file line number Diff line number Diff line change
Expand Up @@ -1065,7 +1065,6 @@ def validate_meta(meta: Optional[CacheMeta], id: str, path: Optional[str],
manager.log('Metadata abandoned for {}: data cache is modified'.format(id))
return None

# TODO: Share stat() outcome with find_module()
path = os.path.abspath(path)
st = manager.get_stat(path) # TODO: Errors
if not stat.S_ISREG(st.st_mode):
Expand Down Expand Up @@ -1310,14 +1309,6 @@ def delete_cache(id: str, path: str, manager: BuildManager) -> None:
d. from P import M; checks filesystem whether module P.M exists in
filesystem.
e. Race conditions, where somebody modifies a file while we're
processing. I propose not to modify the algorithm to handle this,
but to detect when this could lead to inconsistencies. (For
example, when we decide on the dependencies based on cache
metadata, and then we decide to re-parse a file because of a stale
dependency, if the re-parsing leads to a different list of
dependencies we should warn the user or start over.)
Steps
-----
Expand Down Expand Up @@ -1852,11 +1843,6 @@ def compute_dependencies(self) -> None:
if self.id != 'builtins' and 'builtins' not in dep_line_map:
dependencies.append('builtins')

# NOTE: What to do about race conditions (like editing the
# file while mypy runs)? A previous version of this code
# explicitly checked for this, but ran afoul of other reasons
# for differences (e.g. silent mode).

# Missing dependencies will be moved from dependencies to
# suppressed when they fail to be loaded in load_graph.
self.dependencies = dependencies
Expand Down

0 comments on commit 893e1da

Please sign in to comment.