Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed handling of namespace packages in zip files #290

Merged
merged 2 commits into from
Sep 20, 2023

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Sep 19, 2023

@jaraco jaraco changed the base branch from main to refactor/multiplexed-path-traversables September 19, 2023 14:05
Base automatically changed from refactor/multiplexed-path-traversables to main September 19, 2023 14:08
@jaraco
Copy link
Member Author

jaraco commented Sep 20, 2023

Tests are failing on Windows, presumably because of backslashes as separators for zip subdirectories in submodules_search_paths.

@jaraco
Copy link
Member Author

jaraco commented Sep 20, 2023

I confirmed that on Windows, submodules_search_locations uses backslashes:

>>> import pkg
>>> pkg.__spec__
ModuleSpec(name='pkg', loader=<_frozen_importlib_external.NamespaceLoader object at 0x0000021A5C97B3E0>, submodule_search_locations=_NamespacePath(['C:\\Users\\jaraco\\draft\\pkg.zip\\pkg']))

@jaraco jaraco force-pushed the bugfix/namespace-packages-in-zip branch from 5d3d1b8 to 2451ab4 Compare September 20, 2023 15:43
@jaraco jaraco force-pushed the bugfix/namespace-packages-in-zip branch from 2451ab4 to a9b0c92 Compare September 20, 2023 15:53
@jaraco
Copy link
Member Author

jaraco commented Sep 20, 2023

Ignoring diffcov failure again, due to the problems with the library being loaded prior to testing.

@jaraco jaraco merged commit cb4bbdd into main Sep 20, 2023
@jaraco jaraco deleted the bugfix/namespace-packages-in-zip branch September 20, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NotADirectoryError: MultiplexedPath only supports directories
1 participant