-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bypass native readers with files #268
Conversation
jaraco
commented
Oct 5, 2022
•
edited
Loading
edited
- Disable native reader even if it supplies files, because it might not have features/fixes present in this library. Fixes files(...).joinpath doesn't accept variable number of arguments in Python 3.10+ #257.
Verified the fix against the repro:
|
Ignore the first commit. That's on main now and unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, this disregards custom loaders, no? What about simply giving our readers precedence?
ed8fa45
to
9396ffc
Compare
Excellent point. I think I'd missed that consideration, which probably also means that the test suite could use better coverage to capture that use-case. Also, your suggestion to simply give precedence to this module's readers might be an excellent approach. |
… have features/fixes present in this library. Fixes #257.
9396ffc
to
68be8b4
Compare
In this latest chain, I've pushed a test that passes against main but fails with the patch, capturing the concern FFY00 raised. |
I've confirmed that the patch still works for the reported failure:
|