-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More speedup via mtime-base caching. #290
Conversation
Caching based on mtime is similar to the one done on importlib's FileFinder. Locally, on a large-ish environment, this speeds up repeated calls to `distribution("pip")` ~10x.
…om mtime caching behavior.
In an attempt to troubleshoot, I added the following patch:
And then running the cache test, it emits output like this:
So even though only one FastPath is constructed for each root, the 'lookup' cache never has any hits. I've confirmed also that the mtime is unchanged from call to call. I just do not understand why the lookup is not being cached. |
Aha. I've figured it out. The |
Looking at the alternate implementation in #274, I see the difference lies in how the |
Fixed handling of namespace packages in zip files
Extension of #274.