Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError when finder has no __module__ #110

Closed
jaraco opened this issue Oct 22, 2020 · 6 comments
Closed

AttributeError when finder has no __module__ #110

jaraco opened this issue Oct 22, 2020 · 6 comments

Comments

@jaraco
Copy link
Member

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 01:19

As reported in #91:

[The fix for #91] broke compatibility with PyOxidizer whose finder is not attached to a module:

Traceback (most recent call last):
  [...]
  File "importlib_metadata", line 471, in <module>
  File "importlib_metadata._compat", line 62, in install
  File "importlib_metadata._compat", line 79, in disable_stdlib_finder
  File "importlib_metadata._compat", line 76, in matches
AttributeError: 'PyOxidizerFinder' object has no attribute '__module__'
@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 01:59

mentioned in commit a6dbe33324c51f02c6c67317800b10f2a59bcddf

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 02:06

mentioned in commit 98b91d2

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 02:06

mentioned in commit 725935b

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 02:08

mentioned in merge request !112

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 02:20

closed via merge request !112

@jaraco
Copy link
Member Author

jaraco commented Oct 22, 2020

In GitLab by @jaraco on Jan 29, 2020, 02:20

mentioned in commit 3150ed4

@jaraco jaraco closed this as completed Oct 22, 2020
@jaraco jaraco mentioned this issue Oct 22, 2020
Closed
jaraco added a commit that referenced this issue Dec 21, 2023
@jaraco
Defer construction of the zipfile.Path and release the handle after g…
6ab2b58 
…rabbing a temporary file. Closes #110.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jaraco