Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require to backport all documentation and tests changes to stable Python branches #1168

Closed
vstinner opened this issue Sep 26, 2023 · 8 comments
Closed

Require to backport all documentation and tests changes to stable Python branches #1168

vstinner opened this issue Sep 26, 2023 · 8 comments
Labels
good first issue New contributors

Comments

@vstinner
Copy link
Member

All documentation and tests changes done in the Python main branch should be backported to stable branches (currently 3.11 and 3.12). It should be documented in the devguide.

Context: python/cpython#108303 (comment)
@vstinner vstinner mentioned this issue Sep 26, 2023
Closed
@hugovk
Copy link
Member

hugovk commented Sep 26, 2023

This should probably go in https://devguide.python.org/developer-workflow/development-cycle/

(https://devguide.python.org/getting-started/git-boot-camp/#backporting-merged-changes says how to backport, not why/when.)

@AA-Turner AA-Turner added the good first issue New contributors label Sep 26, 2023
@JacobCoffee
Copy link
Member

JacobCoffee commented Sep 26, 2023 •
edited
Loading

Hi, I'd like to grab this if it's not taken

@AA-Turner
Copy link
Member

Go ahead, feel free to ping in the PR for feedback.

A

@JacobCoffee
Copy link
Member

Also does this go along with #1069?

@AA-Turner
Copy link
Member

I'd probably add a note below that list saying that documentation and tests may be backported to any bugfix branch. See also Jelle's notes.

A

JacobCoffee added a commit to JacobCoffee/devguide that referenced this issue Sep 26, 2023
@JacobCoffee
docs(python#1168): add directive on when/where to backport docs and t…
5d269ed 
…esting changes
@JacobCoffee JacobCoffee mentioned this issue Sep 26, 2023
Merged
@JacobCoffee
Copy link
Member

Hi @AA-Turner please see my changes - are they to little or just bad in general? 😅

JacobCoffee added a commit to JacobCoffee/devguide that referenced this issue Sep 28, 2023
@JacobCoffee
docs(python#1168): add directive on backporting
35e855b
@hugovk
Copy link
Member

hugovk commented Oct 6, 2023

Fixed in #1169, thanks @JacobCoffee!

@hugovk hugovk closed this as completed Oct 6, 2023
@vstinner
Copy link
Member Author

vstinner commented Oct 6, 2023

Thanks.

@encukou encukou mentioned this issue Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue New contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vstinner @hugovk @AA-Turner @JacobCoffee