Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.11] gh-99845: _PyObject_DictPointer(): fix dictoffset cast #99922

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[3.11] gh-99845: _PyObject_DictPointer(): fix dictoffset cast #99922

merged 1 commit into from
Dec 1, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Dec 1, 2022 •
edited by bedevere-bot
Loading

Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit Windows, long is 32-bit whereas Py_ssize_t is 64-bit.

@vstinner
gh-99845: _PyObject_DictPointer(): fix dictoffset cast
47a5fcc 
Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit
Windows, long is 32-bit whereas Py_ssize_t is 64-bit.
@bedevere-bot bedevere-bot mentioned this pull request Dec 1, 2022
Closed
@vstinner
Copy link
Member Author

vstinner commented Dec 1, 2022

@serhiy-storchaka: I don't think that it deserves a NEWS entry, since it's unlikely that dictoffset is larger than LONG_MAX (2^31-1 on 64-bit Windows).

@vstinner vstinner mentioned this pull request Dec 1, 2022
Merged
@vstinner vstinner merged commit 9707bf2 into python:3.11 Dec 1, 2022
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@vstinner vstinner deleted the obj_dictptr311 branch December 1, 2022 13:08
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2022
@vstinner @miss-islington
pythongh-99845: _PyObject_DictPointer(): fix dictoffset cast (pythonG…
ba5d5b3 
…H-99922)

Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit
Windows, long is 32-bit whereas Py_ssize_t is 64-bit.
(cherry picked from commit 9707bf2)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-99924 is a backport of this pull request to the 3.10 branch.

@vstinner
Copy link
Member Author

vstinner commented Dec 1, 2022

@serhiy-storchaka: Merged, thanks for the review.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 1, 2022
miss-islington added a commit that referenced this pull request Dec 1, 2022
@miss-islington @vstinner
gh-99845: _PyObject_DictPointer(): fix dictoffset cast (GH-99922)
64dae2e 
Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit
Windows, long is 32-bit whereas Py_ssize_t is 64-bit.
(cherry picked from commit 9707bf2)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vstinner @miss-islington @bedevere-bot @serhiy-storchaka