Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99905: Fix output of misses in summarize_stats.py execution counts #99906

Merged
merged 1 commit into from
Nov 30, 2022
Merged

gh-99905: Fix output of misses in summarize_stats.py execution counts #99906

merged 1 commit into from
Nov 30, 2022

Conversation

mdboom
Copy link
Contributor

@mdboom mdboom commented Nov 30, 2022 •
edited by bedevere-bot
Loading

This was an indentation error introduced in 2844aa6

@mdboom
pythongh-99905: Fix output of misses in summarize_stats.py execution …
5ae4c95 
…counts

This was an indentation error introduced in 2844aa6
@bedevere-bot bedevere-bot mentioned this pull request Nov 30, 2022
Closed
@markshannon
Copy link
Member

LGTM.
This would imply that any instruction with misses would have been absent from the execution counts table, and that seems to be case.

@markshannon markshannon merged commit bf94c65 into python:main Nov 30, 2022
@markshannon
Copy link
Member

Curious to see the updated stats.

@brandtbucher
Copy link
Member

Fun fact: there is a % formatting option that scales by 100 and adds the "%" for you!

@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot wasm32-emscripten node (pthreads) 3.x has failed when building commit bf94c65.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/1050/builds/949) and take a look at the build logs.
  4. Check if the failure is related to this commit (bf94c65) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/1050/builds/949

Failed tests:

  • test_traceback

Failed subtests:

  • test_import_from_error_bad_suggestions_do_not_trigger_for_small_names - test.test_traceback.CPythonSuggestionFormattingTests.test_import_from_error_bad_suggestions_do_not_trigger_for_small_names

Summary of the results of the build (if available):

== Tests result: FAILURE ==

338 tests OK.

10 slowest tests:

  • test_tokenize: 1 min 18 sec
  • test_unparse: 50.6 sec
  • test_lib2to3: 49.4 sec
  • test_io: 39.6 sec
  • test_capi: 36.6 sec
  • test_unicodedata: 23.9 sec
  • test_pickle: 22.1 sec
  • test_argparse: 18.4 sec
  • test_statistics: 18.1 sec
  • test_pathlib: 15.5 sec

1 test failed:
test_traceback

94 tests skipped:
test__xxsubinterpreters test_asyncgen test_asyncio
test_check_c_globals test_clinic test_cmd_line
test_concurrent_futures test_contextlib_async test_ctypes
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_doctest
test_docxmlrpc test_dtrace test_embed test_epoll test_faulthandler
test_fcntl test_file_eintr test_fork1 test_ftplib test_gdb
test_grp test_httplib test_httpservers test_idle test_imaplib
test_interpreters test_ioctl test_kqueue test_launcher test_lzma
test_mmap test_msilib test_multiprocessing_fork
test_multiprocessing_forkserver test_multiprocessing_main_handling
test_multiprocessing_spawn test_nis test_openpty test_ossaudiodev
test_pdb test_peg_generator test_perf_profiler test_poll
test_poplib test_pty test_pwd test_readline test_regrtest
test_repl test_resource test_select test_selectors test_smtplib
test_smtpnet test_socket test_socketserver test_spwd test_ssl
test_stable_abi_ctypes test_startfile test_subprocess
test_sys_settrace test_syslog test_tcl test_telnetlib test_tix
test_tkinter test_tools test_ttk test_ttk_textonly test_turtle
test_urllib2 test_urllib2_localnet test_urllib2net test_urllibnet
test_venv test_wait3 test_wait4 test_webbrowser test_winconsoleio
test_winreg test_winsound test_wmi test_wsgiref test_xmlrpc
test_xmlrpc_net test_xxlimited test_zipfile64
test_zipimport_support test_zoneinfo
0:21:39 load avg: 8.55
0:21:39 load avg: 8.55 Re-running failed tests is not supported with --python host runner option.

Total duration: 21 min 39 sec

Click to see traceback logs 
TracebackCases.test_caret) ... ok


TracebackException.test_traceback_header) ... ok


TracebackException.test_compact_with_cause) ... ok


TracebackErrorCaretTests.test_multiline_method_call_c) ... ok


TracebackErrorCaretTests.test_specialization_variations) ... ok


TracebackErrorCaretTests.test_traceback_very_long_line) ... ok


TracebackFormatTests.test_print_stack) ... ok


TracebackFormatTests.test_print_exception_bad_type_capi) ... ok


TracebackException.test_comparison_params_variations) ... ok


TracebackException.test_smoke) ... ok


TracebackException.test_context) ... ok


TracebackFormatTests.test_format_stack) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression) ... ok


TracebackCases.test_exception_is_None) ... ok


TracebackErrorCaretTests.test_traceback_specialization_with_syntax_error) ... ok


TracebackFormatTests.test_exception_group_deep_recursion_capi) ... ok


TracebackFormatTests.test_print_exception_bad_type_python) ... ok


TracebackException.test_cause) ... ok


TracebackException_ExceptionGroups.test_exception_group_format) ... ok


TracebackFormatTests.test_traceback_format) ... ok


TracebackErrorCaretTests.test_secondary_caret_not_elided) ... ok


TracebackException.test_locals) ... ok


TracebackErrorCaretTests.test_line_with_unicode) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression_syntax_error) ... ok


TracebackCases.test_format_exception_exc) ... ok


TracebackCases.test_base_exception) ... ok


TracebackErrorCaretTests.test_caret_for_subscript) ... ok


TracebackCases.test_format_exception_only_exc) ... ok


TracebackCases.test_clear) ... ok


TracebackFormatTests.test_unhashable) ... ok


TracebackFormatTests.test_traceback_format_with_cleared_frames) ... ok


TracebackErrorCaretTests.test_caret_exception_group) ... ok


TracebackErrorCaretTests.test_wide_characters_unicode_with_problematic_byte_offset) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators_two_char) ... ok


TracebackException.test_compact_no_cause) ... ok


TracebackFormatTests.test_stack_format) ... ok


TracebackCases.test_signatures) ... ok


TracebackCases.test_print_exception) ... ok


TracebackCases.test_no_caret_with_no_debug_ranges_flag_python_traceback) ... skipped 'requires subprocess support'


TracebackException.test_no_locals) ... ok


TracebackException.test_unhashable) ... ok


TracebackCases.test_no_caret_with_no_debug_ranges_flag) ... skipped 'requires subprocess support'


TracebackException.test_long_context_chain) ... ok


TracebackFormatTests.test_exception_group_deep_recursion_traceback) ... ok


TracebackErrorCaretTests.test_caret_for_subscript_unicode) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators_with_unicode) ... ok


TracebackException.test_comparison_equivalent_exceptions_are_equal) ... ok


TracebackErrorCaretTests.test_caret_multiline_expression_bin_op) ... ok


TracebackCases.test_extract_stack) ... ok


TracebackException.test_from_exception) ... ok


TracebackException.test_limit) ... ok


TracebackCases.test_recursion_error_during_traceback) ... skipped 'requires subprocess support'


TracebackCases.test_encoded_file) ... skipped 'requires subprocess support'


TracebackErrorCaretTests.test_multiline_method_call_a) ... ok


TracebackException.test_no_refs_to_exception_and_traceback_objects) ... ok


TracebackFormatTests.test_recursive_traceback_python) ... ok


TracebackCases.test_nocaret) ... ok


TracebackException_ExceptionGroups.test_max_group_depth) ... ok


TracebackException_ExceptionGroups.test_comparison) ... ok


TracebackCases.test_format_exception_only_bad__str__) ... ok


TracebackErrorCaretTests.test_byte_offset_with_wide_characters_middle) ... ok


TracebackException_ExceptionGroups.test_max_group_width) ... ok


TracebackErrorCaretTests.test_multiline_method_call_b) ... ok


TracebackErrorCaretTests.test_decorator_application_lineno_correct) ... ok


TracebackCases.test_print_traceback_at_exit) ... skipped 'requires subprocess support'


TracebackException.test_comparison_basic) ... ok


TracebackCases.test_print_exception_exc) ... ok


TracebackErrorCaretTests.test_basic_caret) ... ok


TracebackErrorCaretTests.test_caret_in_type_annotation) ... ok


TracebackException.test_lookup_lines) ... ok


TracebackErrorCaretTests.test_caret_for_binary_operators) ... ok


Traceback (most recent call last):
  File "/opt/buildbot/bcannon-wasm/3.x.bcannon-wasm.emscripten-node-pthreads/build/Lib/test/test_traceback.py", line 3172, in test_import_from_error_bad_suggestions_do_not_trigger_for_small_names
    self.assertNotIn("vvv", actual)
AssertionError: 'vvv' unexpectedly found in "ImportError: cannot import name 'py' from 'HJhABGVRhVvxvvvx' (/tmp/tmpxye3wg2e/HJhABGVRhVvxvvvx.py)"


TracebackException_ExceptionGroups.test_exception_group_construction) ... ok


TracebackFormatTests.test_recursive_traceback_cpython_internal) ... ok


TracebackException_ExceptionGroups.test_exception_group_format_exception_only) ... ok


TracebackException.test_print) ... ok


TracebackErrorCaretTests.test_byte_offset_multiline) ... ok


TracebackCases.test_bad_indentation) ... ok

@mdboom
Copy link
Contributor Author

mdboom commented Dec 1, 2022

Curious to see the updated stats.

I see you figured out how to kick one off manually.

I deleted the earlier (broken) results from earlier this week since they could be misleading.

carljm added a commit to carljm/cpython that referenced this pull request Dec 1, 2022
@carljm
Merge branch 'main' into fixinspect
12f7659 
* main: (112 commits)
  pythongh-99894: Ensure the local names don't collide with the test file in traceback suggestion error checking (python#99895)
  pythongh-99612: Fix PyUnicode_DecodeUTF8Stateful() for ASCII-only data (pythonGH-99613)
  Doc: Add summary line to isolation_level & autocommit sqlite3.connect params (python#99917)
  pythonGH-98906 ```re``` module: ```search() vs. match()``` section should mention ```fullmatch()``` (pythonGH-98916)
  pythongh-89189: More compact range iterator (pythonGH-27986)
  bpo-47220: Document the optional callback parameter of weakref.WeakMethod (pythonGH-25491)
  pythonGH-99905: Fix output of misses in summarize_stats.py execution counts (pythonGH-99906)
  pythongh-99845: PEP 670: Convert PyObject macros to functions (python#99850)
  pythongh-99845: Use size_t type in __sizeof__() methods (python#99846)
  pythonGH-99877)
  Fix typo in exception message in `multiprocessing.pool` (python#99900)
  pythongh-87092: move all localsplus preparation into separate function called from assembler stage (pythonGH-99869)
  pythongh-99891: Fix infinite recursion in the tokenizer when showing warnings (pythonGH-99893)
  pythongh-99824: Document that sqlite3.connect implicitly open a transaction if autocommit=False (python#99825)
  pythonGH-81057: remove static state from suggestions.c (python#99411)
  Improve zip64 limit error message (python#95892)
  pythongh-98253: Break potential reference cycles in external code worsened by typing.py lru_cache (python#98591)
  pythongh-99127: Allow some features of syslog to the main interpreter only (pythongh-99128)
  pythongh-82836: fix private network check (python#97733)
  Docs: improve accuracy of socketserver reference (python#24767)
  ...
@mdboom mdboom deleted the fix-emitting-misses branch December 22, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markshannon markshannon Awaiting requested review from markshannon

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdboom @markshannon @brandtbucher @bedevere-bot