gh-97731: fix distclean target to clean docs

[smontanaro]

This change makes the distclean target in Makefile.pre.in rely on the clean target in Doc/Makefile to do that part of its job.

• Issue: .gitignore seems a bit too aggressive or make distclean isn't aggressive enough #97731

[smontanaro]

I don't think a NEWS entry is required for this, but I don't see how to add a "skip news" label...

[hugovk]

I added "skip news" by clicking Labels on the right, then filtering by typing in "skip":

[smontanaro]

Thanks @hugovk. "Labels" is inactive for me. I don't know where type-bug came from either. I guess that was the default for a bug report?

[hugovk]

Yes, type-bug is automatically added when using the bug template, defined here:

https://github.com/python/cpython/blob/main/.github/ISSUE_TEMPLATE/bug.md

[orsenthil]

This change looks good to me. I will let the build, release managers comment as it can serve or affect their work.

[vstinner]

LGTM.

[hugovk]

Looks good, reduces duplication.

From the issue:

Doc/tools/{sphinx,pygments,docutils} doesn' exist after executing make -C Doc html. I suspect the docclean target could simply be replaced by make -C Doc clean, and made a dependency of the distclean target.

Those dirs look redundant now.

Deletion of those dirs from the top-level Makefile.pre.in added 15 years ago (8188e63).

Also 15 years ago, Doc/Makefile used to only delete Docs/tools/sphinx (116aa62).

But use of a venv was added 8 years ago (d5ea39d), so dependencies get wiped from the venv dir.

[miss-islington]

Thanks @smontanaro for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

[miss-islington]

Sorry, @smontanaro and @orsenthil, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 46eecc3b33b960d7e692547dd61792533d213e01 3.11

[miss-islington]

Sorry @smontanaro and @orsenthil, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 46eecc3b33b960d7e692547dd61792533d213e01 3.10

[orsenthil]

The cherry_picker failed. Please approve and merge these backports

• [3.10] gh-97731: fix distclean target to clean docs GH-97732 #97846
• [3.11] gh-97731: fix distclean target to clean docs GH-97732 #97844