-
-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93939: Build C extensions without setup.py #94474
Conversation
1a3a959
to
af65a4c
Compare
🤖 New build scheduled with the buildbot fleet by @tiran for commit 1469caf9703e411b73a00169a6bf0c5e688f5e72 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
1469caf
to
68b3032
Compare
🤖 New build scheduled with the buildbot fleet by @tiran for commit 68b3032229ee0185f029772e5e43f72cbb4b402d 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
68b3032
to
11701ba
Compare
Is there a need for force pushes? Github notifications lead to nothing, which is a little annoying. |
FWIW, You can click on "force-pushed" in the event about the force push, to see what changed between the two force-pushes. Submitting feedback to GitHub to have the notifications for force-pushed go to that, instead of "oh, I can't show you what changed" may help make GitHub prioritze fixing that higher. |
I only force push to rebase. It is the easiest and fastest way for me to resolve merge conflicts. The PR has frequent conflicts, even right now. |
40e1554
to
87f243d
Compare
🤖 New build scheduled with the buildbot fleet by @tiran for commit 87f243d764d4909388aed35e59f177d598c096ca 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
setup.py's
|
013af91
to
45e1ba0
Compare
Sorry, I can't merge this PR. Reason: |
#94848 addresses the build issue with LTO + pydebug. |
My little precious setup.py... YOU WILL NEVER BE FORGOTTEN 😭😭😭 _bootsubprocess.py (that I wrote)... I hate you, I'm glad that you're dead! If I recall correctly, I had to write _bootsubprocess to use the clean subprocess module, rather than naive fork+exec code, in distutils. distutils... I also hate you by the way. |
This broke the AIX build with the below error. ./python -E -S -m sysconfig --generate-posix-vars ; Traceback (most recent call last): During handling of the above exception, another exception occurred: Traceback (most recent call last): |
Please open a new bug for the problem. |
I found a regression, reported as #98707 |
Thanks for doing this! |
Combines GH-93940, GH-94452, and GH-94433
Automerge-Triggered-By: GH:tiran