Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93370: Drop deprecated sqlite3.version from pythoninfo.py #94277

Merged
merged 2 commits into from
Jun 26, 2022
Merged

gh-93370: Drop deprecated sqlite3.version from pythoninfo.py #94277

merged 2 commits into from
Jun 26, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 25, 2022 •
edited
Loading

Resolves gh-93370

@serhiy-storchaka
Copy link
Member

I think there is no need to output sqlite3.version.

@erlend-aasland
Copy link
Contributor Author

I think there is no need to output sqlite3.version.

+1
Even better!

@erlend-aasland erlend-aasland changed the title gh-93370: Catch sqlite3.version deprecation warning in pythoninfo.py gh-93370: Drop deprecated sqlite3.version from pythoninfo.py Jun 26, 2022
@erlend-aasland erlend-aasland merged commit 27934be into python:main Jun 26, 2022
@erlend-aasland erlend-aasland deleted the sqlite-pythoninfo branch June 26, 2022 10:10
@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Serhiy.

@erlend-aasland erlend-aasland mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate sqlite3.version and sqlite3.version_info
3 participants
@erlend-aasland @serhiy-storchaka @bedevere-bot