-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-87389: avoid treating path as URI with netloc #93894
Open
nascheme
wants to merge
19
commits into
python:main
Choose a base branch
from
nascheme:urlunsplit_relative
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+83
−17
Commits on Jun 16, 2022
-
wip: alternative fix for pythongh-87389
still needs test for urlunsplit() change
Configuration menu - View commit details
-
Copy full SHA for 4f76c44 - Browse repository at this point
Copy the full SHA 4f76c44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06b3879 - Browse repository at this point
Copy the full SHA 06b3879View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00a3a92 - Browse repository at this point
Copy the full SHA 00a3a92View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8e1cc2 - Browse repository at this point
Copy the full SHA a8e1cc2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 83c8332 - Browse repository at this point
Copy the full SHA 83c8332View commit details -
Configuration menu - View commit details
-
Copy full SHA for f99e80b - Browse repository at this point
Copy the full SHA f99e80bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e542578 - Browse repository at this point
Copy the full SHA e542578View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7b0b15 - Browse repository at this point
Copy the full SHA b7b0b15View commit details -
The pathsplit() function will work correctly on relative paths too so don't say "absolute paths". Improve comment for _get_redirect_url().
Configuration menu - View commit details
-
Copy full SHA for 6915331 - Browse repository at this point
Copy the full SHA 6915331View commit details -
Configuration menu - View commit details
-
Copy full SHA for 915451c - Browse repository at this point
Copy the full SHA 915451cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 952a0f4 - Browse repository at this point
Copy the full SHA 952a0f4View commit details -
Use pathsplit() in translate_path().
This avoids "manual parsing" of the Request-URI part of the request and matches what _get_redirect_url() does.
Configuration menu - View commit details
-
Copy full SHA for 899f512 - Browse repository at this point
Copy the full SHA 899f512View commit details -
Configuration menu - View commit details
-
Copy full SHA for a00656c - Browse repository at this point
Copy the full SHA a00656cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8985853 - Browse repository at this point
Copy the full SHA 8985853View commit details -
Make _get_redirect_url() into a method.
Possible that someone could override this so a method is nicer.
Configuration menu - View commit details
-
Copy full SHA for f1f94ae - Browse repository at this point
Copy the full SHA f1f94aeView commit details -
Futher cleanups, remove urllib.parse.pathsplit().
Since pathsplit() doesn't seem like a generally useful public API, remove it. Instead, add a _request_path_split() method. This ensures that the redirect logic and the translate_path() method use the same path parsing.
Configuration menu - View commit details
-
Copy full SHA for 8a34cd0 - Browse repository at this point
Copy the full SHA 8a34cd0View commit details
Commits on Jul 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 23d4b56 - Browse repository at this point
Copy the full SHA 23d4b56View commit details
Commits on May 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7a71381 - Browse repository at this point
Copy the full SHA 7a71381View commit details -
Configuration menu - View commit details
-
Copy full SHA for d18bbd9 - Browse repository at this point
Copy the full SHA d18bbd9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.