Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-87389: avoid treating path as URI with netloc #93894

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Commits on Jun 16, 2022

  1. wip: alternative fix for pythongh-87389

    still needs test for urlunsplit() change
    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    4f76c44 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06b3879 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    00a3a92 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8e1cc2 View commit details
    Browse the repository at this point in the history
  5. Add blurb.

    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    83c8332 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f99e80b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e542578 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b7b0b15 View commit details
    Browse the repository at this point in the history
  9. Improve comments and docs.

    The pathsplit() function will work correctly on relative paths too so
    don't say "absolute paths".  Improve comment for _get_redirect_url().
    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    6915331 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    915451c View commit details
    Browse the repository at this point in the history
  11. Fix markup in blurb.

    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    952a0f4 View commit details
    Browse the repository at this point in the history
  12. Use pathsplit() in translate_path().

    This avoids "manual parsing" of the Request-URI part of the request and
    matches what _get_redirect_url() does.
    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    899f512 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    a00656c View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8985853 View commit details
    Browse the repository at this point in the history
  15. Make _get_redirect_url() into a method.

    Possible that someone could override this so a method is nicer.
    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    f1f94ae View commit details
    Browse the repository at this point in the history
  16. Futher cleanups, remove urllib.parse.pathsplit().

    Since pathsplit() doesn't seem like a generally useful public API,
    remove it.  Instead, add a _request_path_split() method.  This ensures
    that the redirect logic and the translate_path() method use the same
    path parsing.
    nascheme committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    8a34cd0 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2022

  1. reword news

    gpshead committed Jul 3, 2022
    Configuration menu
    Copy the full SHA
    23d4b56 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Configuration menu
    Copy the full SHA
    7a71381 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d18bbd9 View commit details
    Browse the repository at this point in the history