-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-93121: fix test_mailbox where some test cases were accidentally dropped #93242
Conversation
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The substantive change looks OK, two comments.
A
Misc/NEWS.d/next/Tests/2022-05-26-03-19-46.gh-issue-93121.tTiPpf.rst
Outdated
Show resolved
Hide resolved
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
FWIW, "map" and "mapping" are two different things. |
Misc/NEWS.d/next/Tests/2022-05-28-03-52-49.gh-issue-93121.JsYqsI.rst
Outdated
Show resolved
Hide resolved
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Before:
cpython/Lib/test/test_mailbox.py
Lines 34 to 35 in b2694ab
cpython/Lib/test/test_mailbox.py
Lines 2267 to 2290 in b2694ab
Since
_sample_headers
is a map with duplicate keys (ex:Received
), not all keys are tested.After:
Changed _sample_headers to a list of tuples so all keys are tested
test_mailbox
: Duplicate keys in_sample_headers
cause_check_sample
to only test one value #93121