Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92368: Fix missing possesive apostrophe #92397

Merged
merged 3 commits into from
May 6, 2022
Merged

gh-92368: Fix missing possesive apostrophe #92397

merged 3 commits into from
May 6, 2022

Conversation

gophra
Copy link
Contributor

@gophra gophra commented May 6, 2022

No description provided.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented May 6, 2022 •
edited
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 6, 2022
@kumaraditya303
Copy link
Contributor

Docs entry is not required here as the change is small, please remove it. I applied skip news label.

AlexWaygood
AlexWaygood approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gophra for the PR, and for deleting the news entry!

@ezio-melotti ezio-melotti merged commit a79001e into python:main May 6, 2022
@ezio-melotti ezio-melotti added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 6, 2022
@miss-islington
Copy link
Contributor

Thanks @gophra for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @gophra for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 6, 2022
@bedevere-bot
Copy link

GH-92403 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 6, 2022
@bedevere-bot
Copy link

GH-92404 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 6, 2022
@gophra @miss-islington
pythongh-92368: Fix missing possessive apostrophe (pythonGH-92397)
872b68b 
* Fix missing possessive apostrophe
(cherry picked from commit a79001e)

Co-authored-by: gophra <105054704+gophra@users.noreply.github.com>
@hugovk hugovk mentioned this pull request May 6, 2022
Closed
miss-islington added a commit that referenced this pull request May 6, 2022
@miss-islington @gophra
gh-92368: Fix missing possessive apostrophe (GH-92397)
17f3b5c 
* Fix missing possessive apostrophe
(cherry picked from commit a79001e)

Co-authored-by: gophra <105054704+gophra@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 6, 2022
@miss-islington @gophra
gh-92368: Fix missing possessive apostrophe (GH-92397)
4a2337f 
* Fix missing possessive apostrophe
(cherry picked from commit a79001e)

Co-authored-by: gophra <105054704+gophra@users.noreply.github.com>
@gophra gophra deleted the fix-issue-92368 branch May 6, 2022 14:23
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @gophra @hello-adam
pythongh-92368: Fix missing possessive apostrophe (pythonGH-92397)
00bde4a 
* Fix missing possessive apostrophe
(cherry picked from commit a79001e)

Co-authored-by: gophra <105054704+gophra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gophra @bedevere-bot @kumaraditya303 @miss-islington @AlexWaygood @ezio-melotti