Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-92047: Py_GetVersion multi-digit minor version (GH-92047) #92048

Merged
merged 1 commit into from
May 5, 2022

Conversation

jebob
Copy link
Contributor

@jebob jebob commented Apr 29, 2022

Minor doc change.

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Apr 29, 2022

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot
Copy link

Every change to Python requires a NEWS entry.

Please, add it using the blurb_it Web app or the blurb command-line tool.

@@ -0,0 +1,5 @@
From https://docs.python.org/3.11/c-api/init.html?highlight=py_getversion#c.Py_GetVersion:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this NEWS entry, it's not needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@vstinner
Copy link
Member

vstinner commented May 5, 2022

4 required CI jobs never started. I closed/reopened the PR to schedule new CI jobs.

@vstinner vstinner merged commit 43b135f into python:main May 5, 2022
@vstinner vstinner added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels May 5, 2022
@miss-islington
Copy link
Contributor

Thanks @jebob for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @jebob for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label May 5, 2022
@bedevere-bot
Copy link

GH-92329 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-92330 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 5, 2022
…) (pythonGH-92048)

(cherry picked from commit 43b135f)

Co-authored-by: Robert Howlett <robert@howletts.org.uk>
@vstinner
Copy link
Member

vstinner commented May 5, 2022

Thanks, merged. Firefox got problems with its version... 100, 3 digits :-D See https://hacks.mozilla.org/2022/02/version-100-in-chrome-and-firefox/

vstinner pushed a commit that referenced this pull request May 6, 2022
… (#92330)

(cherry picked from commit 43b135f)

Co-authored-by: Robert Howlett <robert@howletts.org.uk>

Co-authored-by: Robert Howlett <robert@howletts.org.uk>
vstinner pushed a commit that referenced this pull request May 6, 2022
… (#92329)

(cherry picked from commit 43b135f)

Co-authored-by: Robert Howlett <robert@howletts.org.uk>

Co-authored-by: Robert Howlett <robert@howletts.org.uk>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…) (pythonGH-92048) (python#92329)

(cherry picked from commit 43b135f)

Co-authored-by: Robert Howlett <robert@howletts.org.uk>

Co-authored-by: Robert Howlett <robert@howletts.org.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants