gh-91491: What's New in 3.11 section for typing PEPs #91721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Other aspects of typing aren't covered yet; I'll do that in a separate PR.
|
cc PEP authors @davidfstr @mrahtz @pradeep90 @Gobot1234 |
Gobot1234
reviewed
Apr 20, 2022
AlexWaygood
reviewed
Apr 20, 2022
davidfstr
reviewed
Apr 21, 2022
There was a problem hiding this comment.
Added some wordsmithing comments. Thanks for drafting @JelleZijlstra !
|
Thanks everyone for the feedback! I pushed a commit addressing most requests and adding some links. |
pradeep90
approved these changes
Apr 21, 2022
| def __enter__(self) -> Self: | ||
| self.lock() | ||
| return self | ||
|
|
There was a problem hiding this comment.
One important use case is that calling this method on a subclass object will return the subclass type, not this class type. e.g.,
class ChildLock(MyLock): ...
ChildLock().__enter__() # type is `ChildLock`, not `MyLock`.
There was a problem hiding this comment.
Do you think that should be mentioned here? It's meant to be a brief summary after all.
|
LGTM. Thanks, Jelle! |
Gobot1234
approved these changes
Apr 22, 2022
Co-authored-by: Pradeep Kumar <gohanpra@gmail.com>
Fidget-Spinner
approved these changes
Apr 24, 2022
davidfstr
approved these changes
Apr 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other aspects of typing aren't covered yet; I'll do that in a
separate PR.
#91491