[WIP] bpo-32592: Drop support for Windows Vista

[vstinner]

Windows Vista extended support ended in April 2017. As stated in PEP
11, Python 3.7 drops support for Windows Vista and now requires
Windows 7 or newer.

https://bugs.python.org/issue32592

[vstinner]

Hum, the change should be mentionned in Doc/whatsnew/3.7.rst.

[vstinner]

AppVeyor compilation failed with: "C:\Program Files (x86)\Windows Kits\10\Include\10.0.16299.0\shared\sdkddkver.h(289): fatal error C1189: #error: NTDDI_VERSION setting conflicts with _WIN32_WINNT setting [C:\projects\cpython\PCbuild\pythoncore.vcxproj]"

[matrixise]

Maybe you could change the comment before #define Py_HAVE_CONDVAR ?

[matrixise]

in fact, should we remove all the references to Vista when we drop the support of Vista ?

[vstinner]

I updated the comment.

[matrixise]

@vstinner There is some references to Vista in the Tools/msi/ directory.

[vstinner]

@vstinner There is some references to Vista in the Tools/msi/ directory.

I don't know this directory, so I prefer to leave it unchanged.

[matrixise]

@vstinner ok then in this case, the PR seems to be right.

[zooba]

See https://bugs.python.org/issue29871 before pulling this code out - our alternate code isn't 100% correct yet.

[vstinner]

Oh, I can revert this change and propose it in https://bugs.python.org/issue29871.

My change should have no effect on Windows 7 and newer. Why do you prefer to keep the unused emulation code (until bpo-29871 is fixed)?

[vstinner]

AppVeyor compilation failed with: "C:\Program Files (x86)\Windows Kits\10\Include\10.0.16299.0\shared\sdkddkver.h(289): fatal error C1189: #error: NTDDI_VERSION setting conflicts with _WIN32_WINNT setting [C:\projects\cpython\PCbuild\pythoncore.vcxproj]"

@zooba: Do you understand why my change breaks the compilation?

[eryksun]

Isn't removing this a mistake? I think the SRWLOCK version was tried in another issue that was abandoned.

[vstinner]

Hum, this code seems to sensitive and my change may conflict with https://bugs.python.org/issue29871 so I reverted this change and will open a new dedicated PR.

[vstinner]

"posixmodule.obj : error LNK2001: unresolved external symbol _GetMaximumProcessorCount [C:\projects\cpython\PCbuild\pythoncore.vcxproj]"

Oh, my posixmodule.c change doesn't work :-(

Extract of pythoninfo:

sys.windowsversion: sys.getwindowsversion(major=10, minor=0, build=14393, platform=2, service_pack='')
sys.winver: 3.7-32
sys.version: 3.7.0a4+ (heads/master-2-g1d7f51e:1d7f51e, Jan 18 2018, 05:42:21) [MSC v.1912 32 bit (Intel)]

I understand that AppVeyor runs Windows 10 and Python was built by Visual Studio 2017

https://msdn.microsoft.com/fr-fr/library/windows/desktop/dd405489(v=vs.85).aspx

"Remarks: To compile an application that uses this function, set _WIN32_WINNT >= 0x0601. For more information, see Using the Windows Headers."

Aha. I need to try to understand why changing _WIN32_WINNT failed. But my Windows VM is down :-)

[vstinner]

Hum, I'm not sure that my PR is correct anymore. I change its status to WIP, I will rework on it, once I get again access to a Windows VM to fix my PR.

[matrixise]

Some news about this PR ?

…

-- Stéphane Wirtel - http://wirtel.be - @matrixise