-
-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-32436: Implement PEP 567 #5027
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
8192f9a
bpo-32436: Implement PEP 567
1st1 8d0d64c
Add Token.MISSING, token.old_val; token.var
1st1 d846b41
Make PyContextVar_Get return a new ref
1st1 339c283
Explain HAMT
1st1 243175f
Mention how to debug HAMT
1st1 63c38fe
Address review feedback
1st1 c4750a7
ThreadState now refs to a Context object (fixes Context.run/__getitem__)
1st1 b1c97f0
Document hamt_t enum types
1st1 4f10c5e
Add a test
1st1 47d5a99
Add Context.copy() method
1st1 7549c6a
Harden PyContext_Exit to check that the current context matches
1st1 db384f3
Simplify context_new() logic
1st1 e299b4c
Token.reset() checks the context too now
1st1 dad0651
Token.old_val -> Token.old_value
1st1 78b0361
Test that subclassing is prohibited
1st1 3673bd9
Make ContextVar.reset raise an error for already used tokens
1st1 9223883
Drop unused file
1st1 8c82581
Reword a comment
1st1 17fa9c0
Address Inada-sun comments
1st1 52dc25b
Cache empty HAMT node
1st1 81ae871
Don't GC-track ContextVars if name/default are not tracked
1st1 7070cca
Handle an error if rehashing fails
1st1 cc8873c
PyContext_CopyCurrent() & PyContext_Copy() (sync with the PEP)
1st1 e353e95
Fix asynciomodule.c to use new PyContext_CopyCurrent
1st1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,86 @@ | ||
#ifndef Py_CONTEXT_H | ||
#define Py_CONTEXT_H | ||
#ifdef __cplusplus | ||
extern "C" { | ||
#endif | ||
|
||
#ifndef Py_LIMITED_API | ||
|
||
|
||
PyAPI_DATA(PyTypeObject) PyContext_Type; | ||
typedef struct _pycontextobject PyContext; | ||
|
||
PyAPI_DATA(PyTypeObject) PyContextVar_Type; | ||
typedef struct _pycontextvarobject PyContextVar; | ||
|
||
PyAPI_DATA(PyTypeObject) PyContextToken_Type; | ||
typedef struct _pycontexttokenobject PyContextToken; | ||
|
||
|
||
#define PyContext_CheckExact(o) (Py_TYPE(o) == &PyContext_Type) | ||
#define PyContextVar_CheckExact(o) (Py_TYPE(o) == &PyContextVar_Type) | ||
#define PyContextToken_CheckExact(o) (Py_TYPE(o) == &PyContextToken_Type) | ||
|
||
|
||
PyAPI_FUNC(PyContext *) PyContext_New(void); | ||
PyAPI_FUNC(PyContext *) PyContext_Copy(PyContext *); | ||
PyAPI_FUNC(PyContext *) PyContext_CopyCurrent(void); | ||
|
||
PyAPI_FUNC(int) PyContext_Enter(PyContext *); | ||
PyAPI_FUNC(int) PyContext_Exit(PyContext *); | ||
|
||
|
||
/* Create a new context variable. | ||
|
||
default_value can be NULL. | ||
*/ | ||
PyAPI_FUNC(PyContextVar *) PyContextVar_New( | ||
const char *name, PyObject *default_value); | ||
|
||
|
||
/* Get a value for the variable. | ||
|
||
Returns -1 if an error occurred during lookup. | ||
|
||
Returns 0 if value either was or was not found. | ||
|
||
If value was found, *value will point to it. | ||
If not, it will point to: | ||
|
||
- default_value, if not NULL; | ||
- the default value of "var", if not NULL; | ||
- NULL. | ||
|
||
'*value' will be a new ref, if not NULL. | ||
*/ | ||
PyAPI_FUNC(int) PyContextVar_Get( | ||
PyContextVar *var, PyObject *default_value, PyObject **value); | ||
|
||
|
||
/* Set a new value for the variable. | ||
Returns NULL if an error occurs. | ||
*/ | ||
PyAPI_FUNC(PyContextToken *) PyContextVar_Set( | ||
PyContextVar *var, PyObject *value); | ||
|
||
|
||
/* Reset a variable to its previous value. | ||
Returns 0 on sucess, -1 on error. | ||
*/ | ||
PyAPI_FUNC(int) PyContextVar_Reset( | ||
PyContextVar *var, PyContextToken *token); | ||
|
||
|
||
/* This method is exposed only for CPython tests. Don not use it. */ | ||
PyAPI_FUNC(PyObject *) _PyContext_NewHamtForTests(void); | ||
|
||
|
||
PyAPI_FUNC(int) PyContext_ClearFreeList(void); | ||
|
||
|
||
#endif /* !Py_LIMITED_API */ | ||
|
||
#ifdef __cplusplus | ||
} | ||
#endif | ||
#endif /* !Py_CONTEXT_H */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#ifndef Py_INTERNAL_CONTEXT_H | ||
#define Py_INTERNAL_CONTEXT_H | ||
|
||
|
||
#include "internal/hamt.h" | ||
|
||
|
||
struct _pycontextobject { | ||
PyObject_HEAD | ||
PyContext *ctx_prev; | ||
PyHamtObject *ctx_vars; | ||
PyObject *ctx_weakreflist; | ||
int ctx_entered; | ||
}; | ||
|
||
|
||
struct _pycontextvarobject { | ||
PyObject_HEAD | ||
PyObject *var_name; | ||
PyObject *var_default; | ||
PyObject *var_cached; | ||
uint64_t var_cached_tsid; | ||
uint64_t var_cached_tsver; | ||
Py_hash_t var_hash; | ||
}; | ||
|
||
|
||
struct _pycontexttokenobject { | ||
PyObject_HEAD | ||
PyContext *tok_ctx; | ||
PyContextVar *tok_var; | ||
PyObject *tok_oldval; | ||
int tok_used; | ||
}; | ||
|
||
|
||
int _PyContext_Init(void); | ||
void _PyContext_Fini(void); | ||
|
||
|
||
#endif /* !Py_INTERNAL_CONTEXT_H */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
#ifndef Py_INTERNAL_HAMT_H | ||
#define Py_INTERNAL_HAMT_H | ||
|
||
|
||
#define _Py_HAMT_MAX_TREE_DEPTH 7 | ||
|
||
|
||
#define PyHamt_Check(o) (Py_TYPE(o) == &_PyHamt_Type) | ||
|
||
|
||
/* Abstract tree node. */ | ||
typedef struct { | ||
PyObject_HEAD | ||
} PyHamtNode; | ||
|
||
|
||
/* An HAMT immutable mapping collection. */ | ||
typedef struct { | ||
PyObject_HEAD | ||
PyHamtNode *h_root; | ||
PyObject *h_weakreflist; | ||
Py_ssize_t h_count; | ||
} PyHamtObject; | ||
|
||
|
||
/* A struct to hold the state of depth-first traverse of the tree. | ||
|
||
HAMT is an immutable collection. Iterators will hold a strong reference | ||
to it, and every node in the HAMT has strong references to its children. | ||
|
||
So for iterators, we can implement zero allocations and zero reference | ||
inc/dec depth-first iteration. | ||
|
||
- i_nodes: an array of seven pointers to tree nodes | ||
- i_level: the current node in i_nodes | ||
- i_pos: an array of positions within nodes in i_nodes. | ||
*/ | ||
typedef struct { | ||
PyHamtNode *i_nodes[_Py_HAMT_MAX_TREE_DEPTH]; | ||
Py_ssize_t i_pos[_Py_HAMT_MAX_TREE_DEPTH]; | ||
int8_t i_level; | ||
} PyHamtIteratorState; | ||
|
||
|
||
/* Base iterator object. | ||
|
||
Contains the iteration state, a pointer to the HAMT tree, | ||
and a pointer to the 'yield function'. The latter is a simple | ||
function that returns a key/value tuple for the 'Items' iterator, | ||
just a key for the 'Keys' iterator, and a value for the 'Values' | ||
iterator. | ||
*/ | ||
typedef struct { | ||
PyObject_HEAD | ||
PyHamtObject *hi_obj; | ||
PyHamtIteratorState hi_iter; | ||
binaryfunc hi_yield; | ||
} PyHamtIterator; | ||
|
||
|
||
PyAPI_DATA(PyTypeObject) _PyHamt_Type; | ||
PyAPI_DATA(PyTypeObject) _PyHamt_ArrayNode_Type; | ||
PyAPI_DATA(PyTypeObject) _PyHamt_BitmapNode_Type; | ||
PyAPI_DATA(PyTypeObject) _PyHamt_CollisionNode_Type; | ||
PyAPI_DATA(PyTypeObject) _PyHamtKeys_Type; | ||
PyAPI_DATA(PyTypeObject) _PyHamtValues_Type; | ||
PyAPI_DATA(PyTypeObject) _PyHamtItems_Type; | ||
|
||
|
||
/* Create a new HAMT immutable mapping. */ | ||
PyHamtObject * _PyHamt_New(void); | ||
|
||
/* Return a new collection based on "o", but with an additional | ||
key/val pair. */ | ||
PyHamtObject * _PyHamt_Assoc(PyHamtObject *o, PyObject *key, PyObject *val); | ||
|
||
/* Return a new collection based on "o", but without "key". */ | ||
PyHamtObject * _PyHamt_Without(PyHamtObject *o, PyObject *key); | ||
|
||
/* Find "key" in the "o" collection. | ||
|
||
Return: | ||
- -1: An error ocurred. | ||
- 0: "key" wasn't found in "o". | ||
- 1: "key" is in "o"; "*val" is set to its value (a borrowed ref). | ||
*/ | ||
int _PyHamt_Find(PyHamtObject *o, PyObject *key, PyObject **val); | ||
|
||
/* Check if "v" is equal to "w". | ||
|
||
Return: | ||
- 0: v != w | ||
- 1: v == w | ||
- -1: An error occurred. | ||
*/ | ||
int _PyHamt_Eq(PyHamtObject *v, PyHamtObject *w); | ||
|
||
/* Return the size of "o"; equivalent of "len(o)". */ | ||
Py_ssize_t _PyHamt_Len(PyHamtObject *o); | ||
|
||
/* Return a Keys iterator over "o". */ | ||
PyObject * _PyHamt_NewIterKeys(PyHamtObject *o); | ||
|
||
/* Return a Values iterator over "o". */ | ||
PyObject * _PyHamt_NewIterValues(PyHamtObject *o); | ||
|
||
/* Return a Items iterator over "o". */ | ||
PyObject * _PyHamt_NewIterItems(PyHamtObject *o); | ||
|
||
int _PyHamt_Init(void); | ||
void _PyHamt_Fini(void); | ||
|
||
#endif /* !Py_INTERNAL_HAMT_H */ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be moved to internal header?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because we're using it in
_testcapimodule.c
to test the HAMT datatype directly inLib/test/test_context.py
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(unless I'm missing something and it's possible to expose the HAMT type to Python somehow without making a public C API method)