Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29703: asyncio: Fix creating new event loops in child processes. #404

Merged
merged 2 commits into from
Mar 3, 2017
Merged

bpo-29703: asyncio: Fix creating new event loops in child processes. #404

merged 2 commits into from
Mar 3, 2017

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Mar 2, 2017

Proxy issue for python/asyncio#497

@mention-bot
Copy link

@1st1, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Haypo, @tiran, @serhiy-storchaka and @zware to be potential reviewers.

@1st1
Copy link
Member Author

1st1 commented Mar 2, 2017

The PR is already reviewed by @fafhrd91.

@tiran
Copy link
Member

tiran commented Mar 2, 2017

Minor nit pick: The title is slightly confusing. To me a subprocess implies fork+exec. The fix is about fork, so 'child process' or 'forked child' is more descriptive.

@1st1
Copy link
Member Author

1st1 commented Mar 2, 2017

@tiran It's not only about explicitly forked (with os.fork()) child processes, it's also about subprocesses created with multiprocessing, or even concurrent.futures.ProcessPoolExecutor. All in all I agree you wording is better, will update the commit/news message.

@1st1 1st1 changed the title bpo-29703: asyncio: Fix creating new event loops in subprocesses. bpo-29703: asyncio: Fix creating new event loops in child processes. Mar 2, 2017
@1st1
Copy link
Member Author

1st1 commented Mar 2, 2017

@tiran @Haypo Could you please approve this PR? This needs to go in 3.6.1 tomorrow.

@1st1 1st1 merged commit ba7e1f9 into python:master Mar 3, 2017
@1st1 1st1 mentioned this pull request Mar 3, 2017
Merged
1st1 added a commit to 1st1/cpython that referenced this pull request Mar 3, 2017
@1st1
bpo-29703: asyncio: Fix creating new event loops in child processes. (p…
3f44fa5 
…ython#404)
@1st1 1st1 mentioned this pull request Mar 3, 2017
Merged
1st1 added a commit to 1st1/cpython that referenced this pull request Mar 3, 2017
@1st1
bpo-29703: asyncio: Fix creating new event loops in child processes. (p…
3483f98 
…ython#404)
1st1 added a commit that referenced this pull request Mar 3, 2017
@1st1
bpo-29703: asyncio: Fix creating new event loops in child processes. (#…
01e5230 
…404) (#410)
@1st1
Copy link
Member Author

1st1 commented Mar 3, 2017 •
edited
Loading

See also 902e9c5, 80fbacc, 2ef08d3.

1st1 referenced this pull request Mar 3, 2017
@1st1
asyncio: Optimize _get_running_loop() to call getpid() only when ther…
902e9c5 
…e's a loop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@1st1 @mention-bot @tiran @Mariatta @the-knights-who-say-ni