Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46724: Use JUMP_ABSOLUTE for all backward jumps. #31326

Merged
merged 4 commits into from
Feb 15, 2022
Merged

bpo-46724: Use JUMP_ABSOLUTE for all backward jumps. #31326

merged 4 commits into from
Feb 15, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Feb 14, 2022 •
edited by bedevere-bot
Loading

iritkatriel
iritkatriel reviewed Feb 14, 2022
View reviewed changes
Python/compile.c Outdated Show resolved Hide resolved
@iritkatriel
Copy link
Member

It will be interesting to repeat the stats after this.

@iritkatriel
Copy link
Member

This is what I used to get the stats:

https://github.com/faster-cpython/tools/pull/10/files

@JelleZijlstra JelleZijlstra mentioned this pull request Feb 14, 2022
Merged
@markshannon markshannon merged commit 3be1a44 into python:main Feb 15, 2022
@miss-islington
Copy link
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @markshannon, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 3be1a443ca8e7d4ba85f95b78df5c4122cae9ede 3.10

markshannon added a commit that referenced this pull request Feb 15, 2022
@markshannon
bpo-46724: Use JUMP_ABSOLUTE for all backward jumps. (GH-31326)
62303c1 
(cherry picked from commit 3be1a44)
@markshannon markshannon deleted the fix-46724 branch February 15, 2022 09:41
markshannon added a commit that referenced this pull request Feb 15, 2022
@markshannon
bpo-46724: Use JUMP_ABSOLUTE for all backward jumps. (GH-31326)
56330ce 
Backport of GH-31326, plus supporting code from 3.11.
@markshannon markshannon mentioned this pull request Feb 15, 2022
Merged
@bedevere-bot
Copy link

GH-31354 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 15, 2022
markshannon added a commit that referenced this pull request Feb 16, 2022
@markshannon
[3.10] bpo-46724: Use JUMP_ABSOLUTE for all backward jumps. (GH-31326…
d4e4ef1 
…) (GH-31354)
@saulshanabrook saulshanabrook mannequin mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Assignees

@markshannon markshannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@markshannon @iritkatriel @miss-islington @bedevere-bot @the-knights-who-say-ni