Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45753: Make recursion checks more efficient. #29524

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Nov 11, 2021

Should, in theory, be faster.
Seems to provide a small speedup when tested.

https://bugs.python.org/issue45753

@markshannon markshannon force-pushed the speed-up-recursion-check branch from cb874c6 to 84ee4cd Compare November 11, 2021 17:15
@markshannon markshannon force-pushed the speed-up-recursion-check branch from 6f138bd to 0c65e85 Compare November 15, 2021 11:44
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 15, 2021
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 86f2960 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 15, 2021
@markshannon
Copy link
Member Author

Failing buildbots are:

  • 4x Windows. Failing since Friday.
  • Arch Linux Asan: Known failure in gdb test.

@markshannon markshannon merged commit b931077 into python:main Nov 16, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
* Uses recursion remaining, instead of recursion depth to speed up check against recursion limit.
@markshannon markshannon deleted the speed-up-recursion-check branch September 26, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants