[3.8] bpo-41100: Support macOS 11 and Apple Silicon #25274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a partial backport of bpo-41100 changes `e8b1c038b14b5fc8120aab62c9bf5fb840274cb6` and `96d906b144e6e6aa96c5ffebecbcc5d38034bbda` for Python 3.8. We introduce the ability to build Python from source for `arm64` on macOS, but we do not make a promise of support. This allows us to omit support for Universal2 binaries as well as weak-linking of symbols from the macOS SDK based on the deployment target, which are larger changes much more difficult to merge. This also includes a backport of subsequent bpo-42688 change `7e729978fa08a360cbf936dc215ba7dd25a06a08` to fix build errors with external `libffi`.
maxbelanger
commented
Apr 8, 2021
Comment on lines
+514
to
+515
| elif archs == ('arm64', 'x86_64'): | ||
| machine = 'universal2' |
There was a problem hiding this comment.
@ronaldoussoren I'm uncertain whether I should leave in the changes to allow universal2? I don't believe Homebrew requires this, nor would we (Dropbox).
I also don't think universal2 would be very practical given I am not back porting the weak linking changes.
|
We have less than a week to merge this before 3.8 goes into security fixes only mode. |
|
Thanks, @maxbelanger! As noted in bpo-41100, the contents of this PR have been rolled up into #25806. When that PR is resolved, we can close this one. |
|
Thanks for getting this over the finish line, @ned-deily! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial backport of bpo-41100 changes
e8b1c038b14b5fc8120aab62c9bf5fb840274cb6and96d906b144e6e6aa96c5ffebecbcc5d38034bbdafor Python 3.8. We introduce the ability to build Python from source forarm64on macOS, but we do not make a promise of support. This allows us to omit support for weak-linking of symbols from the macOS SDK based on the deployment target, which are larger changes much more difficult to merge.This also includes a backport of subsequent bpo-42688 change
7e729978fa08a360cbf936dc215ba7dd25a06a08to fix build errors with externallibffi.https://bugs.python.org/issue41100