Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41100: Support macOS 11 and Apple Silicon (GH-22855) #23239

Closed
wants to merge 1 commit into from

Conversation

sjmulder
Copy link

@sjmulder sjmulder commented Nov 11, 2020

Backport of commit 4176193 to 3.9:


Co-authored-by: Lawrence D’Anna lawrence_danna@apple.com

  • Add support for macOS 11 and Apple Silicon (aka arm64)

    As a side effect of this work use the system copy of libffi on macOS,
    and remove the vendored copy

  • Support building on recent versions of macOS while deploying to older
    versions

    This allows building installers on macOS 11 while still supporting
    macOS 10.9.

https://bugs.python.org/issue41100

Backport of commit 4176193 to 3.9:
___

Co-authored-by:  Lawrence D’Anna <lawrence_danna@apple.com>

* Add support for macOS 11 and Apple Silicon (aka arm64)

  As a side effect of this work use the system copy of libffi on macOS,
  and remove the vendored copy

* Support building on recent versions of macOS while deploying to older
  versions

  This allows building installers on macOS 11 while still supporting
  macOS 10.9.
@sjmulder sjmulder requested review from abalkin, pganssle, tiran and a team as code owners November 11, 2020 18:44
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@sjmulder

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@sjmulder
Copy link
Author

I haven't done anything with the codebase before so please be gentle. In particular, I don't know if this is the right way to do a backport pull request.

@ned-deily
Copy link
Member

Thanks for the interest but we will be back porting this and other changes to 3.9 soon.

@ned-deily ned-deily closed this Nov 11, 2020
@sjmulder
Copy link
Author

sjmulder commented Nov 11, 2020

Did I do it wrong then? Why can't one submit a backport?

@ned-deily
Copy link
Member

Did I do it wrong then? Why can't one submit a backport?

The core developer(s) handling the original merge to the master branch is normally responsible for deciding what and where to backport and we have automatic tools to help core developers do the work. At first glance, that's what I thought had happened here but, if not, thank you for doing the backport work yourself. Especially with this feature, there are still some pieces to be added so it's best to follow our normal workflow, although it would be interesting to know if you had to manually modify any pieces to backport properly. The process is described in the developers guide, primarily here.

@sjmulder
Copy link
Author

sjmulder commented Nov 12, 2020

Thanks for explaining! I used a regular git cherry pick, there were only a few things to clean up. After that, I had to make two more changes:

These were the minimal changes necessary to get the package building in pkgsrc; there may be more work to do. I’ll be looking forward to the proper release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants