Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) #22574

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[3.8] bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) #22574

merged 1 commit into from
Oct 6, 2020

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Oct 6, 2020 •
edited by bedevere-bot
Loading

Call urllib.request.urlcleanup() to reset the global
urllib.request._opener.
(cherry picked from commit 1fce240)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue41939

@vstinner @miss-islington
bpo-41939: Fix test_site.test_license_exists_at_url() (pythonGH-22559)
4ab7ccd 
Call urllib.request.urlcleanup() to reset the global
urllib.request._opener.
(cherry picked from commit 1fce240)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot mentioned this pull request Oct 6, 2020
Merged
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Oct 6, 2020
@miss-islington
Copy link
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .

vstinner
vstinner approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington
Copy link
Contributor Author

@vstinner and @ambv: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 78bddc7 into python:3.8 Oct 6, 2020
@miss-islington miss-islington deleted the backport-1fce240-3.8 branch October 6, 2020 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miss-islington @vstinner @the-knights-who-say-ni @bedevere-bot