Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-41919: Move the codecs.register operation to the setup of testcases. #22513

Merged
merged 2 commits into from
Oct 16, 2020
Merged

bpo-41919: Move the codecs.register operation to the setup of testcases. #22513

merged 2 commits into from
Oct 16, 2020

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented Oct 3, 2020 •
edited
Loading

  • Move the codecs.register operation to the setup of testcases.
  • Remove _codecs._forget_codecs and _PyCodec_Forget().

https://bugs.python.org/issue41919

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting review labels Oct 3, 2020
@shihai1991
Copy link
Member Author

Hi, victor. Pls take a look when you have free time. @vstinner

vstinner
vstinner reviewed Oct 3, 2020
View reviewed changes
Lib/test/test_codecs.py Show resolved Hide resolved
Lib/test/test_codecs.py Outdated Show resolved Hide resolved
@shihai1991 shihai1991 changed the title bpo-41919: Move the codecs.register operation to testcases. bpo-41919: Move the codecs.register operation to the inside of testcases. Oct 8, 2020
@shihai1991 shihai1991 changed the title bpo-41919: Move the codecs.register operation to the inside of testcases. bpo-41919: Move the codecs.register operation to the setup of testcases. Oct 8, 2020
vstinner
vstinner approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I checked for leaks: ./python -m test test_codecs -R 3:3 pass (no leak), good!

@vstinner vstinner mentioned this pull request Oct 8, 2020
Closed
@shihai1991 shihai1991 closed this Oct 15, 2020
@shihai1991 shihai1991 reopened this Oct 15, 2020
@vstinner
Copy link
Member

It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.

Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.

Or wait until python/core-workflow#377 is fixed (Travis CI made optional).

@shihai1991
Copy link
Member Author

It seems like your PR is sick: it got two Travis CI, and one will never complete. It's a victim of python/core-workflow#377 bug.

Can you try to recreate a new PR? For example, rename your local branch update_test_codecs to update_test_codecs2 and publish it.

Or wait until python/core-workflow#377 is fixed (Travis CI made optional).

Copy that, I can waiting the fix of issues/377 :)

@vstinner vstinner merged commit c9f696c into python:master Oct 16, 2020
@vstinner
Copy link
Member

Copy that, I can waiting the fix of issues/377 :)

Travis CI is no longer mandatory.

I merged your PR, thanks.

@shihai1991
Copy link
Member Author

Copy that, I can waiting the fix of issues/377 :)

Travis CI is no longer mandatory.

I merged your PR, thanks.

Wow, thanks, victor.

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@shihai1991
bpo-41919, test_codecs: Move codecs.register calls to setUp() (python…
9011f3f 
…GH-22513)

* Move the codecs' (un)register operation to testcases.
* Remove _codecs._forget_codec() and _PyCodec_Forget()
pablogsal added a commit that referenced this pull request Oct 25, 2020
@pablogsal
Revert "bpo-41919, test_codecs: Move codecs.register calls to setUp() (…
b1c9a20 
…GH-22513)"

This reverts commit c9f696c.
@pablogsal pablogsal mentioned this pull request Oct 25, 2020
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@shihai1991 @adorilson
bpo-41919, test_codecs: Move codecs.register calls to setUp() (python…
e00b598 
…GH-22513)

* Move the codecs' (un)register operation to testcases.
* Remove _codecs._forget_codec() and _PyCodec_Forget()
@shihai1991 shihai1991 mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shihai1991 @vstinner @corona10 @the-knights-who-say-ni @bedevere-bot