Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40443: Remove unused imports in idlelib #19801

Merged
merged 1 commit into from
Apr 30, 2020
Merged

bpo-40443: Remove unused imports in idlelib #19801

merged 1 commit into from
Apr 30, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 29, 2020 •
edited by bedevere-bot
Loading

@vstinner
Copy link
Member Author

@terryjreedy @csabella: Would you mind to review this PR?

terryjreedy
terryjreedy approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-use verified.

@terryjreedy
Copy link
Member

Don't understand macOS failure, and the abrupt stop. Treating as unrelated intermittent failure.

clang: warning: -framework Tk: 'linker' input unused [-Wunused-command-line-argument]
In file included from /Users/runner/runners/2.169.1/work/cpython/cpython/Modules/_tkinter.c:46:
/Applications/Xcode_11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/tk.h:86:11: fatal error: 'X11/Xlib.h' file not found
#       include <X11/Xlib.h>
                ^~~~~~~~~~~~
1 error generated.

Python build finished successfully!

...
The following modules found by detect_modules() in setup.py, have been

...

@terryjreedy terryjreedy merged commit 6900f16 into python:master Apr 30, 2020
@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @vstinner for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2020
@vstinner @miss-islington
bpo-40443: Remove unused imports in idlelib (pythonGH-19801)
1faed73 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-19808 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 30, 2020
@vstinner @miss-islington
bpo-40443: Remove unused imports in idlelib (pythonGH-19801)
ff8ab3b 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Apr 30, 2020
@bedevere-bot
Copy link

GH-19809 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Apr 30, 2020
@miss-islington @vstinner
bpo-40443: Remove unused imports in idlelib (GH-19801)
48ef06b 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull request Apr 30, 2020
@miss-islington @vstinner
bpo-40443: Remove unused imports in idlelib (GH-19801)
95e208d 
(cherry picked from commit 6900f16)

Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinner vstinner deleted the remove_unused_imports_idle branch April 30, 2020 09:29
@vstinner
Copy link
Member Author

Terry: yeah sadly the macOS CI looks sick :-(

@vstinner vstinner mentioned this pull request Jun 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

@csabella csabella Awaiting requested review from csabella

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni