Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-39984: Pass tstate to _PyEval_SignalAsyncExc() #19049

Merged
merged 1 commit into from
Mar 18, 2020
Merged

bpo-39984: Pass tstate to _PyEval_SignalAsyncExc() #19049

merged 1 commit into from
Mar 18, 2020

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Mar 17, 2020

_PyEval_SignalAsyncExc() and _PyEval_FiniThreads() now expect
tstate, instead of ceval.

https://bugs.python.org/issue39984

@vstinner
Copy link
Member Author

macOS CI failed with:

FAIL: test_daemon_threads_shutdown_stdout_deadlock (test.test_io.CMiscIOTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/runner/runners/2.165.2/work/cpython/cpython/Lib/test/test_io.py", line 4260, in test_daemon_threads_shutdown_stdout_deadlock
    self.check_daemon_threads_shutdown_deadlock('stdout')
  File "/Users/runner/runners/2.165.2/work/cpython/cpython/Lib/test/test_io.py", line 4255, in check_daemon_threads_shutdown_deadlock
    self.assertRegex(err, pattern)
AssertionError: Regex didn't match: "Fatal Python error: _enter_buffered_busy: could not acquire lock for <(_io\\.)?BufferedWriter name='<stdout>'> at interpreter shutdown, possibly due to daemon threads" not found in 'Fatal Python error: Segmentation fault\n\n'

Ubuntu CI failed with:

======================================================================
FAIL: test_mymanager (test.test_multiprocessing_spawn.WithManagerTestMyManager)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 2847, in test_mymanager
    self.assertIn(manager._process.exitcode, (0, -signal.SIGTERM))
AssertionError: -11 not found in (0, -15)

======================================================================
FAIL: test_mymanager_context (test.test_multiprocessing_spawn.WithManagerTestMyManager)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 2855, in test_mymanager_context
    self.assertIn(manager._process.exitcode, (0, -signal.SIGTERM))
AssertionError: -11 not found in (0, -15)

======================================================================
FAIL: test_mymanager_context_prestarted (test.test_multiprocessing_spawn.WithManagerTestMyManager)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython/Lib/test/_test_multiprocessing.py", line 2862, in test_mymanager_context_prestarted
    self.assertEqual(manager._process.exitcode, 0)
AssertionError: -11 != 0

Not good.

@vstinner
Copy link
Member Author

I wrote PR #19054 to fix these crashes.

_PyEval_SignalAsyncExc() and _PyEval_FiniThreads() now expect tstate,
instead of ceval.
@vstinner vstinner merged commit 56bfdeb into python:master Mar 18, 2020
@vstinner vstinner deleted the ceval_tstate branch March 18, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants