Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: minor amendments to runpy.rst #18416

Merged
merged 7 commits into from
Jan 23, 2024
Merged

Docs: minor amendments to runpy.rst #18416

merged 7 commits into from
Jan 23, 2024

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Feb 9, 2020 •
edited by erlend-aasland
Loading

This PR will:

  • fix the typo in mod_name + '.__main__;
  • fix punctuation;
  • fix the formatting of some parameters;
  • add missing possessive forms;
  • use the parameter file_path;
  • use the verb “execute” consistently.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Feb 9, 2020
KenanHArik
KenanHArik reviewed Feb 11, 2020
View reviewed changes
Doc/library/runpy.rst Outdated Show resolved Hide resolved
KenanHArik
KenanHArik reviewed Feb 11, 2020
View reviewed changes
Doc/library/runpy.rst Outdated Show resolved Hide resolved
@KenanHArik
Copy link

At PyCascades Sprint. I have reviewed the proposed language updates and added a few suggestions. Other than that it looks good to me. @willingc can you please review. Thanks!

@geryogam
Copy link
Contributor Author

@KenanHArik Thanks for you reviewing this.

matrixise
matrixise previously requested changes Mar 5, 2020
View reviewed changes
Copy link
Member

@matrixise matrixise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your proposal

Doc/library/runpy.rst Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@geryogam
Copy link
Contributor Author

geryogam commented Mar 5, 2020

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@matrixise: please review the changes made to this pull request.

@bedevere-bot bedevere-bot requested a review from matrixise March 5, 2020 11:33
@AlexWaygood AlexWaygood changed the title Update runpy.rst Minor edits to runpy docs Oct 30, 2022
@erlend-aasland erlend-aasland changed the title Minor edits to runpy docs Docs: minor amendments to runpy.rst Jan 22, 2024
erlend-aasland
erlend-aasland reviewed Jan 22, 2024
View reviewed changes
Doc/library/runpy.rst Outdated Show resolved Hide resolved
Doc/library/runpy.rst Outdated Show resolved Hide resolved
Doc/library/runpy.rst Outdated Show resolved Hide resolved
Doc/library/runpy.rst Outdated Show resolved Hide resolved
Doc/library/runpy.rst Outdated Show resolved Hide resolved
Doc/library/runpy.rst Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland dismissed matrixise’s stale review January 22, 2024 23:56

Stéphane's remark was addressed

@erlend-aasland erlend-aasland enabled auto-merge (squash) January 22, 2024 23:59
@erlend-aasland erlend-aasland merged commit 647b6cc into python:main Jan 23, 2024
24 of 25 checks passed
@geryogam geryogam deleted the patch-13 branch January 24, 2024 22:26
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@geryogam @aisk
Docs: minor amendments to runpy.rst (python#18416)
39e376b 
- Add missing single quote in inline code
- Align parameter formatting with style guide recommendations
- Fix punctuation around parenthesised sentence
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@geryogam @Glyphack
Docs: minor amendments to runpy.rst (python#18416)
2b9828e 
- Add missing single quote in inline code
- Align parameter formatting with style guide recommendations
- Fix punctuation around parenthesised sentence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenanHArik KenanHArik KenanHArik left review comments

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@matrixise matrixise Awaiting requested review from matrixise

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@geryogam @KenanHArik @bedevere-bot @matrixise @erlend-aasland @the-knights-who-say-ni @ezio-melotti @AlexWaygood