Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36842: Fix reference leak in tests by running out-of-proc #13556

Merged
merged 2 commits into from
May 29, 2019
Merged

bpo-36842: Fix reference leak in tests by running out-of-proc #13556

merged 2 commits into from
May 29, 2019

Conversation

zooba
Copy link
Member

@zooba zooba commented May 24, 2019 •
edited by bedevere-bot
Loading

@zooba zooba added skip news tests Tests in the Lib/test dir labels May 24, 2019
@zooba zooba requested a review from vstinner May 24, 2019 19:10
vstinner
vstinner reviewed May 24, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds fine to run tests in a subprocess to prevent false when hunting reference leaks (hooks cannot be unregistered). But I'm not sure about running individual tests one by one. I suggest to run the whole script, so rely on unittest.main() test discovery. Otherwise, there is a risk of forgetting the related test method in test_audit.py. test_eintr uses a similar approach.

Lib/test/test_audit.py Outdated Show resolved Hide resolved
@zooba
Copy link
Member Author

zooba commented May 24, 2019

If the tests are run separately, it reduces the risk of them interfering with each other, and also helps with tracking test results over time.

@zooba zooba merged commit 9ddc416 into python:master May 29, 2019
@zooba zooba deleted the bpo-36842-leak branch May 29, 2019 15:20
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@zooba @DinoV
bpo-36842: Fix reference leak in tests by running out-of-proc (python…
780e8a9 
…GH-13556)
vstinner added a commit that referenced this pull request Apr 14, 2020
@vstinner @zooba
Update libregrtest from master (GH-19517)
b894b66 
* bpo-36670: regrtest bug fixes (GH-16537)

* Fix TestWorkerProcess.__repr__(): start_time is only valid
  if _popen is not None.
* Fix _kill(): don't set _killed to True if _popen is None.
* _run_process(): only set _killed to False after calling
  run_test_in_subprocess().

(cherry picked from commit 2ea71a0)

* [3.8] Update libregrtest from master (GH-19516)

* bpo-37531: regrtest now catchs ProcessLookupError (GH-16827)

Fix a warning on a race condition on TestWorkerProcess.kill(): ignore
silently ProcessLookupError rather than logging an useless warning.

(cherry picked from commit a661392)

* bpo-38502: regrtest uses process groups if available (GH-16829)

test.regrtest now uses process groups in the multiprocessing mode
(-jN command line option) if process groups are available: if
os.setsid() and os.killpg() functions are available.

(cherry picked from commit ecb035c)

* bpo-37957: Allow regrtest to receive a file with test (and subtests) to ignore (GH-16989)

When building Python in some uncommon platforms there are some known tests that will fail. Right now, the test suite has the ability to ignore entire tests using the -x option and to receive a filter file using the --matchfile filter. The problem with the --matchfile option is that it receives a file with patterns to accept and when you want to ignore a couple of tests and subtests, is too cumbersome to lists ALL tests that are not the ones that you want to accept and he problem with -x is that is not easy to ignore just a subtests that fail and the whole test needs to be ignored.

For these reasons, add a new option to allow to ignore a list of test and subtests for these situations.

(cherry picked from commit e0cd8aa)

* regrtest: log timeout at startup (GH-19514)

Reduce also worker timeout.

(cherry picked from commit 4cf65a6)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
(cherry picked from commit 67b8a1f)

* bpo-36842: Fix reference leak in tests by running out-of-proc (GH-13556)

(cherry picked from commit 9ddc416)

* Backport libregrtest changes from master

Co-authored-by: Steve Dower <steve.dower@python.org>
@zooba zooba mentioned this pull request Jun 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner left review comments

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zooba @vstinner @the-knights-who-say-ni @bedevere-bot