-
-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-36895: Undocument removed time.clock #13286
Conversation
`time.clock` has been removed; undocument it and add its removal in the what's new.
7ebcd54
to
9086686
Compare
Updated with both of your suggestions. |
Doc/whatsnew/3.8.rst
Outdated
@@ -788,6 +788,9 @@ The following features and APIs have been removed from Python 3.8: | |||
* The function :func:`platform.popen` has been removed, it was deprecated since | |||
Python 3.3: use :func:`os.popen` instead. | |||
|
|||
* The function :func:`time.clock` has been removed, it was deprecated since Python | |||
3.3: use :func:`time.perf_counter` or :func:`time.process_time` instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, you should copy-paste the end of the sentence :-) Add: ", depending on your requirements, to have a well defined behaviour".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh. I'm the original author of "behaviour" spelling. I have been told in the meanwhile that "behaviour" is the UK spelling, but Python doc prefers US spelling: "behavior" ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks.
Thanks.
…On Mon, 13 May 2019 at 12:24, Victor Stinner ***@***.***> wrote:
Merged #13286 <#13286> into master.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#13286?email_source=notifications&email_token=AACR5TZUZ5I2C2W6FUAMKRDPVG55JA5CNFSM4HMQ7EB2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGORNNM5QA#event-2337984192>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACR5T47H7HDM5VTUTH32ELPVG55JANCNFSM4HMQ7EBQ>
.
|
Thanks for removing time.clock. I was trying to remove it since Python 3.3. I'm the one who deprecated it when I designed and implemented the PEP 418 ;-) |
Always happy to cleanup deprecated features, and have something simpler. I always believe that having a nice, coherent and informative messages with a clear policies and path forward help users adopt new version. |
time.clock
has been removed; undocument it and add its removal in thewhat's new.
https://bugs.python.org/issue36895