Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-36895: Undocument removed time.clock #13286

Merged
merged 3 commits into from
May 13, 2019

Conversation

Carreau
Copy link
Contributor

@Carreau Carreau commented May 13, 2019

time.clock has been removed; undocument it and add its removal in the
what's new.

https://bugs.python.org/issue36895

Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.8.rst Outdated Show resolved Hide resolved
`time.clock` has been removed; undocument it and add its removal in the
what's new.
@Carreau
Copy link
Contributor Author

Carreau commented May 13, 2019

Updated with both of your suggestions.

@@ -788,6 +788,9 @@ The following features and APIs have been removed from Python 3.8:
* The function :func:`platform.popen` has been removed, it was deprecated since
Python 3.3: use :func:`os.popen` instead.

* The function :func:`time.clock` has been removed, it was deprecated since Python
3.3: use :func:`time.perf_counter` or :func:`time.process_time` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, you should copy-paste the end of the sentence :-) Add: ", depending on your requirements, to have a well defined behaviour".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. I'm the original author of "behaviour" spelling. I have been told in the meanwhile that "behaviour" is the UK spelling, but Python doc prefers US spelling: "behavior" ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks.

@vstinner vstinner merged commit b6a09ae into python:master May 13, 2019
@Carreau
Copy link
Contributor Author

Carreau commented May 13, 2019 via email

@vstinner
Copy link
Member

Thanks.

Thanks for removing time.clock. I was trying to remove it since Python 3.3. I'm the one who deprecated it when I designed and implemented the PEP 418 ;-)

@Carreau Carreau deleted the undocument-time-clock branch May 13, 2019 22:35
@Carreau
Copy link
Contributor Author

Carreau commented May 13, 2019

Always happy to cleanup deprecated features, and have something simpler. I always believe that having a nice, coherent and informative messages with a clear policies and path forward help users adopt new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants