bpo-21536: On Android, C extensions are linked to libpython #12989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auvipy
approved these changes
Apr 28, 2019
|
LGTM. Thanks @xdegaye for this fix! I tested the PR on Linux: C extensions are still not linked to libpython, as expected. Xavier tested the cross-compilation to Android. |
|
Note: This is a follow-up to #12946. |
embray
reviewed
May 24, 2019
| @@ -4647,6 +4647,14 @@ AC_MSG_CHECKING(LDVERSION) | |||
| LDVERSION='$(VERSION)$(ABIFLAGS)' | |||
| AC_MSG_RESULT($LDVERSION) | |||
|
|
|||
| # On Android the shared libraries must be linked with libpython. | |||
| AC_SUBST(LIBPYTHON) | |||
| if test -z "$ANDROID_API_LEVEL"; then | |||
There was a problem hiding this comment.
Out of curiosity, being that I'm unfamiliar with build issues on Android why the specific test for $ANDROID_API_LEVEL and not something more generic like:
case $host in
*-linux-android*) ....
?
Reason being, I need to add additional cases where libpython should be linked explicitly (e.g. Cygwin, MinGW, etc.) and it would be easier to build off the host_os for this than something very Android-specific.
There was a problem hiding this comment.
Using a test based on $ANDROID_API_LEVEL or on $host as you suggest is equivalent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue21536