-
-
Notifications
You must be signed in to change notification settings - Fork 31k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-118761: improve import time for pickle
#128732
Conversation
Importing `pickle` is now roughly 25% faster. Importing the `re` module is no longer needed and thus is no more implicitly exposed as `pickle.re`.
0c5d01a
to
6ce7785
Compare
pickle
pickle
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
I'll merge this one tomorrow (and will check if removing EDIT: no micro-optimization so leaving the numbers as is |
As a follow-up, I can also improve the import time of |
@vstinner I plan to merge this one with the following commit message:
and following title:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We can remove the
re
import which takes quite a long time. Benchmarks were performed on a RELEASE build (no PGO, no LTO). It's a bit hard to have stable numbers with-X importtime
, so I'm only using thehyperfine
benchmarks.PR
Main
Since something that is no more present in the global namespace is removed, I've added a NEWS entry and a detailed changelog.