-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-111178: fix UBSan failures in Modules/{blake2,md5,sha1,sha2,sha3}module.c
#128248
Conversation
Modules/{sha1,sha2,sh3,md5}module.c
Modules/{blake2,md5,sha1,sha2,sha3}module.c
One nitpick to keep in mind for the future: C standard reserves identifiers that start with underscore and capital letter, so e.g. defining |
Oh... I was not aware of this. All my branches use an underscore so that the macro is really thought as being private. I can update the PRs locally as they are not yet pushed if you think it's something we should do. |
Effective commits
blake2module.c
md5module.c
sha1module.c
sha2module.c
sha3module.c
Cosmetics
{md5,sha*,blake2}module.c