Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-21879: Improve exception message for str.format #12675

Merged
merged 1 commit into from
Jun 1, 2019
Merged

bpo-21879: Improve exception message for str.format #12675

merged 1 commit into from
Jun 1, 2019

Conversation

franciscouzo
Copy link
Contributor

@franciscouzo franciscouzo commented Apr 3, 2019 •
edited by bedevere-bot
Loading

@nanjekyejoannah
Copy link
Contributor

@franciscouzo , do you want to add a news feed? You can use blub it (https://blurb-it.herokuapp.com/add_blurb).

SylvainDe
SylvainDe reviewed Apr 13, 2019
View reviewed changes
Copy link
Contributor

@SylvainDe SylvainDe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting change! Thanks for contributing!
From what I've seen in the past, code related to error messages tend to get easily (slightly) broken. It could be a good idea to write a unit test for this :)

@rhettinger rhettinger merged commit 9843bc1 into python:master Jun 1, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@franciscouzo @DinoV
Improve exception message for str.format (pythonGH-12675)
ef559ae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SylvainDe SylvainDe SylvainDe left review comments

@ZackerySpytz ZackerySpytz ZackerySpytz left review comments

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@franciscouzo @nanjekyejoannah @SylvainDe @ZackerySpytz @rhettinger @the-knights-who-say-ni @bedevere-bot