Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-125741: Update check_generated_files CI to use our published container image #125744

Merged
merged 7 commits into from
Oct 20, 2024
Merged

gh-125741: Update check_generated_files CI to use our published container image #125744

merged 7 commits into from
Oct 20, 2024

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Oct 20, 2024 •
edited by hugovk
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 20, 2024
Open
@corona10 corona10 marked this pull request as ready for review October 20, 2024 02:33
@corona10
Copy link
Member Author

@erlend-aasland @hugovk

I verified the the workflows well through https://github.com/python/cpython/actions/runs/11422707050/job/31781018424
This PR separates the task from check_generated_files but for unifying to the single task, we may need full unified devcontainer images to be used at https://github.com/python/cpython-devcontainers

Let's handle it separately.

@Damien-Chen
Copy link
Contributor

Since the container python used has something different from Github Action official base image and that is the reason why we should switch to the internal container ?

@corona10
Copy link
Member Author

corona10 commented Oct 20, 2024 •
edited
Loading

See: https://discuss.python.org/t/pinning-gnu-autotools-using-the-github-container-registry/47437/29

FYI, The purpose of CI is verification of whether the person generate autoconf properly

So that’s why we have to unify the image to be same.

@erlend-aasland
Copy link
Contributor

Thanks. I need this for #125571.

@hugovk hugovk changed the title gh-125741: Update check_generated_files CI to use our published conta… gh-125741: Update check_generated_files CI to use our published container image Oct 20, 2024
hugovk
hugovk approved these changes Oct 20, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@corona10 @hugovk
Update .github/workflows/build.yml
91a4f55 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@corona10 corona10 enabled auto-merge (squash) October 20, 2024 07:31
@corona10 corona10 merged commit ed24702 into python:main Oct 20, 2024
36 checks passed
@Damien-Chen
Copy link
Contributor

Does that should be backport to 3.13 and 3.12 ?

@erlend-aasland
Copy link
Contributor

Does that should be backport to 3.13 and 3.12 ?

I think we should backport it, yes. Hugo?

@hugovk
Copy link
Member

hugovk commented Oct 20, 2024

Yes, it'll be easier to maintain if the three branches are more similar.

@erlend-aasland erlend-aasland added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Oct 20, 2024
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@miss-islington-app

This comment was marked as outdated.

Sign in to view
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2024

GH-125759 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 20, 2024
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Oct 20, 2024
@corona10 @erlend-aasland
[3.13] pythongh-125741: Update check_generated_files CI to use our pu…
8bfcaa1 
…blished container image (pythongh-125744)

(cherry picked from commit ed24702)

Co-authored-by: Donghee Na <donghee.na@python.org>
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app
Copy link

bedevere-app bot commented Oct 20, 2024

GH-125760 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Oct 20, 2024
erlend-aasland pushed a commit to erlend-aasland/cpython that referenced this pull request Oct 20, 2024
@corona10 @erlend-aasland
[3.12] pythongh-125741: Update check_generated_files CI to use our pu…
941e5c3 
…blished container image (pythongh-125744)

(cherry picked from commit ed24702)

Co-authored-by: Donghee Na <donghee.na@python.org>
@corona10 corona10 mentioned this pull request Oct 20, 2024
Merged
@AA-Turner AA-Turner mentioned this pull request Oct 21, 2024
Merged
erlend-aasland added a commit that referenced this pull request Oct 21, 2024
@erlend-aasland @corona10
[3.13] gh-125741: Update check_generated_files CI to use our publishe…
a6d81b4 
…d container image (gh-125744) (#125759)

(cherry picked from commit ed24702)

Co-authored-by: Donghee Na <donghee.na@python.org>
erlend-aasland added a commit that referenced this pull request Oct 21, 2024
@erlend-aasland @corona10
[3.12] gh-125741: Update check_generated_files CI to use our publishe…
2bc2aae 
…d container image (gh-125744) (#125760)

(cherry picked from commit ed24702)

Co-authored-by: Donghee Na <donghee.na@python.org>
@sobolevn sobolevn mentioned this pull request Nov 12, 2024
Merged
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@corona10 @ebonnal
pythongh-125741: Update check_generated_files CI to use our published…
b4e9908 
… container image (pythongh-125744)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@hugovk hugovk hugovk approved these changes

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Assignees

@corona10 corona10

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @Damien-Chen @erlend-aasland @hugovk