Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#12… #125476

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Oct 14, 2024

@Eclips4
Copy link
Member Author

Eclips4 commented Oct 14, 2024

cc @kumaraditya303

@Eclips4
Copy link
Member Author

Eclips4 commented Oct 14, 2024

Note for others: We have decided to revert the d5dbbf4 until the root cause has been fixed.

@kumaraditya303 kumaraditya303 added the needs backport to 3.13 bugs and security fixes label Oct 14, 2024
@kumaraditya303 kumaraditya303 enabled auto-merge (squash) October 14, 2024 17:42
@kumaraditya303 kumaraditya303 merged commit e99650b into python:main Oct 14, 2024
37 checks passed
@miss-islington-app
Copy link

Thanks @Eclips4 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@Eclips4 Eclips4 deleted the revert branch October 14, 2024 17:59
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2024
…PyFuture refcycles (pythonGH-12… (pythonGH-125476)

Revert "pythongh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (pythonGH-124959)"

This reverts commit d5dbbf4.
(cherry picked from commit e99650b)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
@bedevere-app
Copy link

bedevere-app bot commented Oct 14, 2024

GH-125478 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 14, 2024
graingert added a commit to graingert/cpython that referenced this pull request Oct 14, 2024
1st1 pushed a commit that referenced this pull request Oct 14, 2024
…p and _PyFuture refcycles ... (#125486)

* Revert "gh-125472: Revert "gh-124958: fix asyncio.TaskGroup and _PyFuture refcycles (#12… (#125476)"

This reverts commit e99650b.

* fix incompatability with gh-124392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants