GH-123516: Improve JIT memory consumption by invalidating cold executors #124443
+125
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trowski/cpython into jit-mem-invalidate-10
savannahostrowski
requested review from
markshannon and
ericsnowcurrently
as code owners
| @@ -1289,6 +1289,11 @@ _Py_HandlePending(PyThreadState *tstate) | |||
| _Py_RunGC(tstate); | |||
| } | |||
|
|
|||
| if((breaker & _PY_EVAL_JIT_INVALIDATE_COLD_BIT) != 0) { | |||
| _Py_unset_eval_breaker_bit(tstate, _PY_EVAL_JIT_INVALIDATE_COLD_BIT); | |||
| _Py_Executors_InvalidateCold(tstate->interp); | |||
There was a problem hiding this comment.
Just a thought I had while reading through... I don't think any of the stuff that manipulates the linked list of executors is thread-safe currently. Probably not a problem for this PR, but in the future we'll probably want to go through and add _PyEval_StopTheWorld and _PyEval_StartTheWorld calls in optimize.c.
brandtbucher
approved these changes
Sep 25, 2024
picnixz
reviewed
Sep 25, 2024
Comment on lines
+1682
to
+1684
| if (!exec->vm_data.warm && PyList_Append(invalidate, (PyObject *)exec) < 0) { | ||
| goto error; | ||
| } |
There was a problem hiding this comment.
Suggested change
| if (!exec->vm_data.warm && PyList_Append(invalidate, (PyObject *)exec) < 0) { | |
| goto error; | |
| } | |
| if (!exec->vm_data.warm && PyList_Append(invalidate, (PyObject *)exec) < 0) { | |
| goto error; | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR succeeds #123402 and reworks the approach to use the eval breaker for the invalidation call instead of executor creation or gc (thanks @markshannon!). In experimenting, I tried a couple of different thresholds of 10k, 100k, and 1 million runs. The benchmarks for 100k and 1 million were most promising. Here are some relevant stats for quick reference:
100k
1 million
After chatting with @brandtbucher, I've opted to open this PR with the 100k threshold. One thing to note is that we are potentially a little too liberal in invalidating executors with this threshold, but with the lack of movement in performance and a more substantial decrease in memory usage, it seemed justified. We can continue to iterate here and consider making this tunable in the future.