Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-117139: Replace _PyList_FromArraySteal with stack ref variant #122830

Merged
merged 1 commit into from
Aug 12, 2024
Merged

gh-117139: Replace _PyList_FromArraySteal with stack ref variant #122830

merged 1 commit into from
Aug 12, 2024

Conversation

colesbury
Copy link
Contributor

@colesbury colesbury commented Aug 8, 2024 •
edited by bedevere-app bot
Loading

This replaces _PyList_FromArraySteal with _PyList_FromStackRefSteal. It's functionally equivalent, but takes a _PyStackRef array instead of an array of PyObject pointers.

@colesbury @Fidget-Spinner
pythongh-117139: Replace _PyList_FromArraySteal with stack ref variant
47d3235 
This replaces `_PyList_FromArraySteal` with `_PyList_FromStackRefSteal`.
It's functionally equivalent, but takes a `_PyStackRef` array instead of
an array of `PyObject` pointers.

Co-authored-by: Ken Jin <kenjin@python.org>
@bedevere-app bedevere-app bot mentioned this pull request Aug 8, 2024
Closed
@colesbury
Copy link
Contributor Author

This was extracted from @Fidget-Spinner's PR:

@colesbury colesbury marked this pull request as ready for review August 8, 2024 17:48
DinoV
DinoV approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@colesbury colesbury merged commit ab094d1 into python:main Aug 12, 2024
66 of 68 checks passed
@colesbury colesbury deleted the gh-117139-list-steal branch August 12, 2024 18:49
blhsing pushed a commit to blhsing/cpython that referenced this pull request Aug 22, 2024
@colesbury @Fidget-Spinner @blhsing
pythongh-117139: Replace _PyList_FromArraySteal with stack ref variant (
d678b1c 
python#122830)

This replaces `_PyList_FromArraySteal` with `_PyList_FromStackRefSteal`.
It's functionally equivalent, but takes a `_PyStackRef` array instead of
an array of `PyObject` pointers.

Co-authored-by: Ken Jin <kenjin@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DinoV DinoV DinoV approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

Assignees
No one assigned
Labels
skip news topic-free-threading
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colesbury @DinoV