-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-122332: Fix missing NULL
check in asyncio.Task.get_coro
#122338
gh-122332: Fix missing NULL
check in asyncio.Task.get_coro
#122338
Conversation
ZeroIntensity
commented
Jul 27, 2024
- Issue: Eager task factory segfaults when hosting and calling an API from the same event loop #122332
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a unit test for this? Something that would currently segfault.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Added it, it's basically a translation of my reproducer in #122332. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks @ZeroIntensity for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
…ythonGH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
…ythonGH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
GH-122344 is a backport of this pull request to the 3.13 branch. |
GH-122345 is a backport of this pull request to the 3.12 branch. |
…GH-122338) (#122345) gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
…GH-122338) (#122344) gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338) (cherry picked from commit c086962) Co-authored-by: Peter Bierma <zintensitydev@gmail.com>