Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122332: Fix missing NULL check in asyncio.Task.get_coro #122338

Merged
merged 5 commits into from
Jul 27, 2024

Conversation

ZeroIntensity
Copy link
Member

Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for this? Something that would currently segfault.

Modules/_asynciomodule.c Outdated Show resolved Hide resolved
ZeroIntensity and others added 2 commits July 26, 2024 23:44
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@ZeroIntensity
Copy link
Member Author

Could you add a unit test for this? Something that would currently segfault.

Added it, it's basically a translation of my reproducer in #122332.

@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 27, 2024
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kumaraditya303 kumaraditya303 merged commit c086962 into python:main Jul 27, 2024
43 checks passed
@miss-islington-app
Copy link

Thanks @ZeroIntensity for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
…ythonGH-122338)

(cherry picked from commit c086962)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 27, 2024
…ythonGH-122338)

(cherry picked from commit c086962)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 27, 2024

GH-122344 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 27, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jul 27, 2024

GH-122345 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 27, 2024
kumaraditya303 pushed a commit that referenced this pull request Jul 27, 2024
…GH-122338) (#122345)

gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338)
(cherry picked from commit c086962)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
kumaraditya303 pushed a commit that referenced this pull request Jul 27, 2024
…GH-122338) (#122344)

gh-122332: Fix missing `NULL` check in `asyncio.Task.get_coro` (GH-122338)
(cherry picked from commit c086962)

Co-authored-by: Peter Bierma <zintensitydev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants