Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] gh-117482: Fix the Slot Wrapper Inheritance Tests #122249

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Jul 24, 2024

The tests were only checking cases where the slot wrapper was present in the initial case. They were missing when the slot wrapper was added in the additional initializations. This fixes that.

(This is effectively a backport of gh-122248.)

@ericsnowcurrently
Copy link
Member Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 109e250 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@ericsnowcurrently ericsnowcurrently merged commit 10cf7d6 into python:3.13 Jul 29, 2024
34 checks passed
@ericsnowcurrently ericsnowcurrently deleted the fix-slot-wrapper-inheritance-tests-3.13 branch July 29, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants