-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-121423: Improve import time of socket
by writing socket.errorTab
as a constant and lazy import modules
#121424
Merged
Merged
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1724a3c
Speed up `socket.errotTab` and lazy import `selectors`
Wulian233 6559ebb
lint
Wulian233 984a3b2
typo
Wulian233 1823c9a
lower().startswith("win")
Wulian233 dce6cd2
Update Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.v…
Wulian233 276d0bb
lint
Wulian233 feae2fa
Update Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.v…
Wulian233 bd771c8
comment describing the intentional lazy import
gpshead fa169f8
Merge branch 'main' into socket
hauntsaninja 1773d04
lazy array
Wulian233 412a3d2
separate imports
Wulian233 fa49395
undo 3.14.rst
Wulian233 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading status checks…
Update Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.v…
…nxrl4.rst Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com>
- Loading branch information
commit dce6cd26f334ca6f35764438c2163f38d2bf2ad3
There are no files selected for viewing
2 changes: 1 addition & 1 deletion
2
Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-121423.vnxrl4.rst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Speed up socket.errorTab and lazy import selectors | ||
Improve import time of `mod`:`socket` by writing `socket.errorTab` as a constant and lazy import of `mod`:`selectors`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to
Misc/NEWS.d/next/Library/2024-07-06-12-37-10.gh-issue-118761.vnxrl4.rst
(containinggh-issue-118761
) and we're ready to merge :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#121423 is the right issue.