-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-106597: Remove unnecessary CFrame offsets #121369
Merged
pablogsal
merged 1 commit into
python:main
from
P403n1x87:py-debugoffsets-remove-cframe-offsets
Jul 4, 2024
Merged
gh-106597: Remove unnecessary CFrame offsets #121369
pablogsal
merged 1 commit into
python:main
from
P403n1x87:py-debugoffsets-remove-cframe-offsets
Jul 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PyCFrame structure has been removed in 3.13 therefore its offsets are no longer available to be exported via the debug offsets structure.
@vstinner @pablogsal some cleanup for 3.13 and main. |
pablogsal
approved these changes
Jul 4, 2024
pablogsal
approved these changes
Jul 4, 2024
Thanks @P403n1x87 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 4, 2024
(cherry picked from commit f5c8d67) Co-authored-by: Gabriele N. Tornetta <P403n1x87@users.noreply.github.com>
GH-121370 is a backport of this pull request to the 3.13 branch. |
vstinner
pushed a commit
that referenced
this pull request
Jul 4, 2024
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PyCFrame structure has been removed in 3.13 therefore its offsets are no longer available to be exported via the debug offsets structure.