-
-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-120433: Mention chocolatey
for installing llvm on Windows as an alternative option
#120434
Conversation
cc @savannahostrowski |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is the run: https://github.com/python/cpython/actions/runs/9489036340 I don't know why, but it's because the workflow file used for the run doesn't contain the Which were added in #119147 and are still in |
I've created #120435 to try to fix that. name: JIT
on:
pull_request:
paths:
- '!**/*.md'
- '!**/*.ini'
- '**jit**'
- 'Python/bytecodes.c'
- 'Python/optimizer*.c'
- '!Python/perf_jit_trampoline.c'
push:
paths:
- '!**/*.md'
- '!**/*.ini'
- '**jit**'
- 'Python/bytecodes.c'
- 'Python/optimizer*.c'
- '!Python/perf_jit_trampoline.c' |
So it does... I missed them because the PR added them to the end of the lists, not the top: 🤔 - '**jit**'
- 'Python/bytecodes.c'
- 'Python/optimizer*.c'
+ - '!Python/perf_jit_trampoline.c'
+ - '!**/*.md'
+ - '!**/*.ini'
push:
paths:
- '**jit**'
- 'Python/bytecodes.c'
- 'Python/optimizer*.c'
+ - '!Python/perf_jit_trampoline.c'
+ - '!**/*.md'
+ - '!**/*.ini' I wonder why they're different. |
Tools/jit/README.md
Outdated
Alternatively, you can use [chocolatey](https://chocolatey.org): | ||
|
||
```sh | ||
choco install llvm --version=18.1.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to specify just --version=18
, without minor and patch releases? Other tools do not specify exact version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to specify just
--version=18
, without minor and patch releases? Other tools do not specify exact version.
Unfortunately, no.
We can also omit --version
and the latest stable release will be installed. What do you think about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to stick to a version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, here's the list of available versions:
llvm 18.1.6 [Approved] Downloads cached for licensed users
llvm 18.1.5 [Approved] Downloads cached for licensed users
llvm 18.1.4 [Approved] Downloads cached for licensed users
llvm 18.1.3 [Approved]
llvm 18.1.2 [Approved]
llvm 18.1.0 [Approved] Downloads cached for licensed users
Which one do you prefer? The latest one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would have to update it from time to time, but there's no other way, I guess ;)
Thanks!
…s as an alternative option (pythonGH-120434) (cherry picked from commit 95737bb) Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
GH-120651 is a backport of this pull request to the 3.13 branch. |
…s as an alternative option (python#120434)
…s as an alternative option (python#120434)
…s as an alternative option (python#120434)
chocolatey
inTools/jit/README.md
#120433