Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119770: Make termios ioctl() constants positive #119840

Merged
merged 1 commit into from
May 31, 2024
Merged

gh-119770: Make termios ioctl() constants positive #119840

merged 1 commit into from
May 31, 2024

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented May 31, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 31, 2024
Closed
@vstinner vstinner force-pushed the termios_positive branch 2 times, most recently from 8dd2f14 to 9db77ce Compare May 31, 2024 11:04
@vstinner vstinner force-pushed the termios_positive branch from 9db77ce to e586f65 Compare May 31, 2024 11:06
@vstinner vstinner mentioned this pull request May 31, 2024
Closed
@vstinner
Copy link
Member Author

@Eclips4 or @sobolevn: Would you mind to try this fix on macOS?

@Eclips4 Eclips4 self-assigned this May 31, 2024
Eclips4
Eclips4 approved these changes May 31, 2024
View reviewed changes
Copy link
Member

@Eclips4 Eclips4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested it locally and everything worked as expected. Thank you Victor!

@Eclips4 Eclips4 added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 31, 2024
@vstinner vstinner merged commit 64ff1e2 into python:main May 31, 2024
38 checks passed
@vstinner vstinner deleted the termios_positive branch May 31, 2024 15:18
@miss-islington-app
Copy link

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@vstinner @miss-islington
pythongh-119770: Make termios ioctl() constants positive (pythonGH-11…
a612c80 
…9840)

(cherry picked from commit 64ff1e2)

Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2024
@vstinner @miss-islington
pythongh-119770: Make termios ioctl() constants positive (pythonGH-11…
3286fcd 
…9840)

(cherry picked from commit 64ff1e2)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link

bedevere-app bot commented May 31, 2024

GH-119862 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 31, 2024
@vstinner vstinner removed the needs backport to 3.12 bug and security fixes label May 31, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 31, 2024

GH-119863 is a backport of this pull request to the 3.12 branch.

@vstinner
Copy link
Member Author

@Eclips4 added needs backport to 3.12 needs backport to 3.13 labels

Oh no, I disagree. That's a backward incompatible change. I don't think that we should backport it. It's not a bugfix. In Python 3.13, "it just works".

This change was needed because I changed ioctl() request parameter type from C unsigned int to C unsigned long in Python 3.14.

@Eclips4
Copy link
Member

Eclips4 commented May 31, 2024 •
edited
Loading

This change was needed because I changed ioctl() request parameter type from C unsigned int to C unsigned long in Python 3.14.

But this change was backported to versions 3.12 and 3.13, so shouldn't it also be backported since it fixes at least one failing test?
#119504
#119505

@Eclips4
Copy link
Member

Eclips4 commented May 31, 2024

Or another option: reverting this change for 3.12 && 3.13 branches since this break backwards compatibility

@vstinner
Copy link
Member Author

vstinner commented Jun 1, 2024

Or another option: reverting this change for 3.12 && 3.13 branches since this break backwards compatibility

Right, I created two revert changes:

noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@vstinner @noahbkim
pythongh-119770: Make termios ioctl() constants positive (python#119840)
4c3bdae
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@vstinner @estyxx
pythongh-119770: Make termios ioctl() constants positive (python#119840)
8f4af9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eclips4 Eclips4 Eclips4 approved these changes

Assignees

@Eclips4 Eclips4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vstinner @Eclips4