Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-119555: catch SyntaxError from compile() in the InteractiveColoredConsole #119557

Merged
merged 3 commits into from
May 29, 2024
Merged

gh-119555: catch SyntaxError from compile() in the InteractiveColoredConsole #119557

merged 3 commits into from
May 29, 2024

Conversation

skirpichev
Copy link
Member

@skirpichev skirpichev commented May 25, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request May 25, 2024
Closed
@AlexWaygood AlexWaygood added needs backport to 3.13 bugs and security fixes topic-repl Related to the interactive shell labels May 25, 2024
@skirpichev skirpichev mentioned this pull request May 29, 2024
Closed
@pablogsal pablogsal merged commit 86d1a1a into python:main May 29, 2024
41 checks passed
@miss-islington-app
Copy link

Thanks @skirpichev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 29, 2024
@skirpichev @miss-islington
pythongh-119555: catch SyntaxError from compile() in the InteractiveC…
530a5b1 
…oloredConsole (pythonGH-119557)

(cherry picked from commit 86d1a1a)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@pablogsal
Copy link
Member

Thanks for the fix @skirpichev 🖤

@bedevere-app
Copy link

bedevere-app bot commented May 29, 2024

GH-119709 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 29, 2024
@skirpichev skirpichev deleted the catch-syntaxerror-compile-119555 branch May 29, 2024 07:01
pablogsal pushed a commit that referenced this pull request May 29, 2024
@miss-islington
[3.13] gh-119555: catch SyntaxError from compile() in the Interactive…
40a024c 
…ColoredConsole (GH-119557) (#119709)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@skirpichev @noahbkim
pythongh-119555: catch SyntaxError from compile() in the InteractiveC…
29cbc3a 
…oloredConsole (python#119557)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@skirpichev @estyxx
pythongh-119555: catch SyntaxError from compile() in the InteractiveC…
b38bdb4 
…oloredConsole (python#119557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal pablogsal approved these changes

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees
No one assigned
Labels
topic-repl Related to the interactive shell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skirpichev @pablogsal @JelleZijlstra @AlexWaygood