Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-119317: findall instead of traverse for docutils nodes #119319

Merged

Conversation

drts01
Copy link
Contributor

@drts01 drts01 commented May 21, 2024

The new method, findall, is a generator rather than returning a list.

closes #119317

@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@drts01 drts01 force-pushed the fix_docs_tools_deprecation_warnings_119317 branch from 2312026 to 3830593 Compare May 21, 2024 16:11
@bedevere-app
Copy link

bedevere-app bot commented May 21, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@willingc willingc added docs Documentation in the Doc dir skip news labels May 21, 2024
@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels May 24, 2024
@hugovk
Copy link
Member

hugovk commented May 24, 2024

Thank you.

@hugovk hugovk merged commit 0867bce into python:main May 24, 2024
29 checks passed
@miss-islington-app
Copy link

Thanks @xsc27 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
…onGH-119319)

(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
@bedevere-app
Copy link

bedevere-app bot commented May 24, 2024

GH-119486 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 24, 2024
…onGH-119319)

(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label May 24, 2024
@bedevere-app
Copy link

bedevere-app bot commented May 24, 2024

GH-119487 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label May 24, 2024
hugovk pushed a commit that referenced this pull request May 24, 2024
…119319) (#119487)

gh-119317: findall instead of traverse for docutils nodes (GH-119319)
(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
hugovk pushed a commit that referenced this pull request May 27, 2024
…119319) (#119486)

gh-119317: findall instead of traverse for docutils nodes (GH-119319)
(cherry picked from commit 0867bce)

Co-authored-by: Carlos Meza <hire@carlosmeza.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve deprecation warnings in Docs/tools
3 participants